Re: [Qemu-devel] [PATCH 4/7] target-mips: use DSP unions for binary DSP operators

2012-12-04 Thread Johnson, Eric
emu-devel] [PATCH 4/7] target-mips: use DSP unions for binary > DSP operators > > This allow to reduce the number of macros. > > Signed-off-by: Aurelien Jarno > --- > target-mips/dsp_helper.c | 384 ++--- > - > 1 file changed, 116 i

Re: [Qemu-devel] [PATCH 4/7] target-mips: use DSP unions for binary DSP operators

2012-11-16 Thread Richard Henderson
On 11/16/2012 03:04 AM, Aurelien Jarno wrote: > +return (int32_t)ds.sw[0]; \ Why the extra cast? You know what type .sw is... r~

[Qemu-devel] [PATCH 4/7] target-mips: use DSP unions for binary DSP operators

2012-11-16 Thread Aurelien Jarno
This allow to reduce the number of macros. Signed-off-by: Aurelien Jarno --- target-mips/dsp_helper.c | 384 ++ 1 file changed, 116 insertions(+), 268 deletions(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index 8015d8d..931ca7