Re: [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution

2009-11-30 Thread Avi Kivity
On 11/30/2009 01:44 PM, Glauber Costa wrote: I really dislike this. In general vcpu ioctls are used as components of some work to be done, for example RMW of some state. In this case it is meaningless to execute the ioctls remotely, you need to execute the entire RMW remotely instead. W

Re: [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution

2009-11-30 Thread Glauber Costa
> > I really dislike this.  In general vcpu ioctls are used as components of > some work to be done, for example RMW of some state.  In this case it is > meaningless to execute the ioctls remotely, you need to execute the entire > RMW remotely instead. > Why? The "M" part of RMW is executed in sha

Re: [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution

2009-11-29 Thread Avi Kivity
On 11/26/2009 07:24 PM, Glauber Costa wrote: This function is similar to qemu-kvm's on_vcpu mechanism. Totally synchronous, and guarantees that a given function will be executed at the specified vcpu. The approach I am taking is to put it under the hood, in kvm_vcpu_ioctl. This way, the kvm_vcpu

[Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution

2009-11-26 Thread Glauber Costa
This function is similar to qemu-kvm's on_vcpu mechanism. Totally synchronous, and guarantees that a given function will be executed at the specified vcpu. The approach I am taking is to put it under the hood, in kvm_vcpu_ioctl. This way, the kvm_vcpu_ioctl can be used anywhere, and we guarantee i