Re: [Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim

2018-08-25 Thread Max Reitz
On 2018-08-22 23:55, John Snow wrote: > > > On 08/22/2018 07:58 AM, Max Reitz wrote: >> On 2018-08-17 21:18, John Snow wrote: >>> >>> >>> On 08/17/2018 03:04 PM, John Snow wrote: Change the manual deferment to commit_complete into the implicit callback to job_exit, renaming commit_compl

Re: [Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim

2018-08-22 Thread John Snow
On 08/22/2018 07:58 AM, Max Reitz wrote: > On 2018-08-17 21:18, John Snow wrote: >> >> >> On 08/17/2018 03:04 PM, John Snow wrote: >>> Change the manual deferment to commit_complete into the implicit >>> callback to job_exit, renaming commit_complete to commit_exit. >>> >>> This conversion does

Re: [Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim

2018-08-22 Thread Max Reitz
On 2018-08-17 21:18, John Snow wrote: > > > On 08/17/2018 03:04 PM, John Snow wrote: >> Change the manual deferment to commit_complete into the implicit >> callback to job_exit, renaming commit_complete to commit_exit. >> >> This conversion does change the timing of when job_completed is >> calle

Re: [Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim

2018-08-22 Thread Max Reitz
On 2018-08-17 21:04, John Snow wrote: > Change the manual deferment to commit_complete into the implicit > callback to job_exit, renaming commit_complete to commit_exit. > > This conversion does change the timing of when job_completed is > called to after the bdrv_replace_node and bdrv_unref calls

Re: [Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim

2018-08-17 Thread John Snow
On 08/17/2018 03:04 PM, John Snow wrote: > Change the manual deferment to commit_complete into the implicit > callback to job_exit, renaming commit_complete to commit_exit. > > This conversion does change the timing of when job_completed is > called to after the bdrv_replace_node and bdrv_unref

[Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim

2018-08-17 Thread John Snow
Change the manual deferment to commit_complete into the implicit callback to job_exit, renaming commit_complete to commit_exit. This conversion does change the timing of when job_completed is called to after the bdrv_replace_node and bdrv_unref calls, which could have implications for bjob->blk wh