Re: [Qemu-devel] [PATCH 4/6] tests: check if qemu-nbd is still alive before waiting

2018-11-19 Thread Daniel P . Berrangé
On Fri, Nov 16, 2018 at 10:24:54AM -0600, Eric Blake wrote: > On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: > > If the qemu-nbd UNIX socket has not shown up, the tests will sleep a bit > > and then check again repeatedly for upto 30 seconds. This is pointless > > s/upto/up to/ > > > if the qemu-

Re: [Qemu-devel] [PATCH 4/6] tests: check if qemu-nbd is still alive before waiting

2018-11-16 Thread Eric Blake
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: If the qemu-nbd UNIX socket has not shown up, the tests will sleep a bit and then check again repeatedly for upto 30 seconds. This is pointless s/upto/up to/ if the qemu-nbd process has quit due to an error, so check whether the pid is still aliv

[Qemu-devel] [PATCH 4/6] tests: check if qemu-nbd is still alive before waiting

2018-11-16 Thread Daniel P . Berrangé
If the qemu-nbd UNIX socket has not shown up, the tests will sleep a bit and then check again repeatedly for upto 30 seconds. This is pointless if the qemu-nbd process has quit due to an error, so check whether the pid is still alive before waiting and retrying. Signed-off-by: Daniel P. Berrangé