Re: [Qemu-devel] [PATCH 4/6] spapr: sanitize error handling in spapr_ics_create()

2017-05-15 Thread David Gibson
On Mon, May 15, 2017 at 01:39:45PM +0200, Greg Kurz wrote: > The spapr_ics_create() function handles errors in a rather convoluted > way, with two local Error * variables. Moreover, failing to parent the > ICS object to the machine should be considered as a bug but it is > currently ignored. > > T

Re: [Qemu-devel] [PATCH 4/6] spapr: sanitize error handling in spapr_ics_create()

2017-05-15 Thread David Gibson
On Mon, May 15, 2017 at 02:06:18PM +0200, Greg Kurz wrote: > On Mon, 15 May 2017 13:59:33 +0200 > Cédric Le Goater wrote: > > > On 05/15/2017 01:39 PM, Greg Kurz wrote: > > > The spapr_ics_create() function handles errors in a rather convoluted > > > way, with two local Error * variables. Moreove

Re: [Qemu-devel] [PATCH 4/6] spapr: sanitize error handling in spapr_ics_create()

2017-05-15 Thread Greg Kurz
On Mon, 15 May 2017 13:59:33 +0200 Cédric Le Goater wrote: > On 05/15/2017 01:39 PM, Greg Kurz wrote: > > The spapr_ics_create() function handles errors in a rather convoluted > > way, with two local Error * variables. Moreover, failing to parent the > > ICS object to the machine should be consid

Re: [Qemu-devel] [PATCH 4/6] spapr: sanitize error handling in spapr_ics_create()

2017-05-15 Thread Cédric Le Goater
On 05/15/2017 01:39 PM, Greg Kurz wrote: > The spapr_ics_create() function handles errors in a rather convoluted > way, with two local Error * variables. Moreover, failing to parent the > ICS object to the machine should be considered as a bug but it is > currently ignored. I am not sure what shou

[Qemu-devel] [PATCH 4/6] spapr: sanitize error handling in spapr_ics_create()

2017-05-15 Thread Greg Kurz
The spapr_ics_create() function handles errors in a rather convoluted way, with two local Error * variables. Moreover, failing to parent the ICS object to the machine should be considered as a bug but it is currently ignored. This patch addresses both issues. Signed-off-by: Greg Kurz --- hw/ppc