Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-10 Thread Wenchao Xia
Using unit byte now, thanks. Am 04.09.2012 15:49, schrieb Paolo Bonzini: Il 04/09/2012 13:38, Eric Blake ha scritto: Since qemu does not support it now, yes, you can ignore it for now. But please make sure that you aren't hard-coding it into the API - that is, make sure that the API can somed

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Kevin Wolf
Am 04.09.2012 15:49, schrieb Paolo Bonzini: > Il 04/09/2012 13:38, Eric Blake ha scritto: >> Since qemu does not support it now, yes, you can ignore it for now. But >> please make sure that you aren't hard-coding it into the API - that is, >> make sure that the API can someday grow to support larg

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 13:38, Eric Blake ha scritto: > Since qemu does not support it now, yes, you can ignore it for now. But > please make sure that you aren't hard-coding it into the API - that is, > make sure that the API can someday grow to support larger sector sizes > with minimal impact to library

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Eric Blake
On 09/04/2012 01:15 AM, Wenchao Xia wrote: > 于 2012-9-3 23:18, Paolo Bonzini 写道: >> Il 03/09/2012 16:28, Eric Blake ha scritto: > +/* this file contains helper function used internally. */ > +#define SECTOR_SIZE (512) >>> Hard-coding this feels wrong, in this day and age of disks with 4096

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 09:15, Wenchao Xia ha scritto: > +/* this file contains helper function used internally. */ > +#define SECTOR_SIZE (512) >>> Hard-coding this feels wrong, in this day and age of disks with 4096 >>> sectors. Why isn't this a per-image property? >> >> In this day and age of dis

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Wenchao Xia
于 2012-9-3 23:18, Paolo Bonzini 写道: Il 03/09/2012 16:28, Eric Blake ha scritto: +/* this file contains helper function used internally. */ +#define SECTOR_SIZE (512) Hard-coding this feels wrong, in this day and age of disks with 4096 sectors. Why isn't this a per-image property? In this day

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-03 Thread Wenchao Xia
于 2012-9-3 21:18, Paolo Bonzini 写道: Il 03/09/2012 11:18, Wenchao Xia ha scritto: This patch contains internal helper codes. Signed-off-by: Wenchao Xia --- block.c |2 +- block.h |1 + libqblock/libqblock-helper.c | 92 +

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-03 Thread Paolo Bonzini
Il 03/09/2012 16:28, Eric Blake ha scritto: >> > +/* this file contains helper function used internally. */ >> > +#define SECTOR_SIZE (512) > Hard-coding this feels wrong, in this day and age of disks with 4096 > sectors. Why isn't this a per-image property? In this day and age of disks with 4096

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-03 Thread Eric Blake
On 09/03/2012 03:18 AM, Wenchao Xia wrote: > This patch contains internal helper codes. > > Signed-off-by: Wenchao Xia > --- > block.c |2 +- > block.h |1 + > libqblock/libqblock-helper.c | 92 > ++ >

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-03 Thread Paolo Bonzini
Il 03/09/2012 11:18, Wenchao Xia ha scritto: > This patch contains internal helper codes. > > Signed-off-by: Wenchao Xia > --- > block.c |2 +- > block.h |1 + > libqblock/libqblock-helper.c | 92 > ++

[Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-03 Thread Wenchao Xia
This patch contains internal helper codes. Signed-off-by: Wenchao Xia --- block.c |2 +- block.h |1 + libqblock/libqblock-helper.c | 92 ++ libqblock/libqblock-helper.h | 57 +