Ian Molton wrote:
>>> +static void virtio_rng_save(QEMUFile *f, void *opaque)
>>> +{
>>> +VirtIORng *s = opaque;
>>> +
>>> +virtio_save(&s->vdev, f);
>>> +}
>>> +
>>> +static int virtio_rng_load(QEMUFile *f, void *opaque, int version_id)
>>> +{
>>> +VirtIORng *s = opaque;
>>> +
>>> +
Anthony Liguori wrote:
>> +DEFINE_RNG_PROPERTIES(VirtIOPCIProxy, rng),
>>
>
> I don't see any reason to use a define here.
Consistency with the other virtio code (at the time I wrote it)
> Coding style is off here (newline between ) and { ).
Fixed.
> Can't call gettimeofday di
Gerd Hoffmann wrote:
> Hi,
>
>>> + PCI_VENDOR_ID_REDHAT_QUMRANET,
>>> + PCI_DEVICE_ID_VIRTIO_RNG,
>>
>> Gerd (or the right person at Red Hat) needs to Ack the assignment of
>> this PCI device id.
>
> Using the first unused one should be ok, I'll double check that though.
> pci-ids.txt must be u
On 02/01/2010 10:03 AM, Gerd Hoffmann wrote:
Hi,
+ PCI_VENDOR_ID_REDHAT_QUMRANET,
+ PCI_DEVICE_ID_VIRTIO_RNG,
Gerd (or the right person at Red Hat) needs to Ack the assignment of
this PCI device id.
Using the first unused one should be ok, I'll double check that though.
pci-ids.txt must b
Hi,
+ PCI_VENDOR_ID_REDHAT_QUMRANET,
+ PCI_DEVICE_ID_VIRTIO_RNG,
Gerd (or the right person at Red Hat) needs to Ack the assignment of
this PCI device id.
Using the first unused one should be ok, I'll double check that though.
pci-ids.txt must be updated too.
cheers,
Gerd
On 02/01/2010 07:34 AM, Ian Molton wrote:
This patch adds support for virtio-rng. Data is read from a chardev and
can be either raw entropy or received via the EGD protocol.
Signed-off-by: Ian Molton
---
Makefile.target |2 +-
hw/pci.h|1 +
hw/virtio-pci.c | 27
This patch adds support for virtio-rng. Data is read from a chardev and
can be either raw entropy or received via the EGD protocol.
Signed-off-by: Ian Molton
---
Makefile.target |2 +-
hw/pci.h|1 +
hw/virtio-pci.c | 27 +++
hw/virtio-rng.c | 202 ++