Re: [Qemu-devel] [PATCH 4/5] scripts: qmp-shell: add transaction subshell

2015-04-22 Thread Eric Blake
On 04/22/2015 09:02 AM, John Snow wrote: > Yeah, not a big deal. The function that invokes this one actually > explicitly checks for an empty string and avoids __build_cmd already. > > If it gets spaces, It actually currently errors out with "list index out > of range" which is not helpful or int

Re: [Qemu-devel] [PATCH 4/5] scripts: qmp-shell: add transaction subshell

2015-04-22 Thread John Snow
On 04/22/2015 10:48 AM, Eric Blake wrote: On 04/21/2015 08:02 PM, John Snow wrote: Add a special processing mode to craft transactions. By entering "transaction(" the shell will enter a special mode where each subsequent command will be saved as a transaction instead of executed as an individ

Re: [Qemu-devel] [PATCH 4/5] scripts: qmp-shell: add transaction subshell

2015-04-22 Thread Eric Blake
On 04/21/2015 08:02 PM, John Snow wrote: > Add a special processing mode to craft transactions. > > By entering "transaction(" the shell will enter a special > mode where each subsequent command will be saved as a transaction > instead of executed as an individual command. > > The transaction can

[Qemu-devel] [PATCH 4/5] scripts: qmp-shell: add transaction subshell

2015-04-21 Thread John Snow
Add a special processing mode to craft transactions. By entering "transaction(" the shell will enter a special mode where each subsequent command will be saved as a transaction instead of executed as an individual command. The transaction can be submitted by entering ")" on a line by itself. Exa