Re: [Qemu-devel] [PATCH 4/5] qemu-ga: win32: isolate virtio-serial specific code

2012-11-01 Thread Michael Roth
On Thu, Nov 01, 2012 at 02:33:29PM -0200, Luiz Capitulino wrote: > On Thu, 1 Nov 2012 11:22:13 -0500 > Michael Roth wrote: > > > On Wed, Oct 31, 2012 at 03:45:19PM -0200, Luiz Capitulino wrote: > > > This commit prepares ga_channel_new(), ga_channel_read() and > > > ga_channel_open() for isa-seri

Re: [Qemu-devel] [PATCH 4/5] qemu-ga: win32: isolate virtio-serial specific code

2012-11-01 Thread Luiz Capitulino
On Thu, 1 Nov 2012 11:22:13 -0500 Michael Roth wrote: > On Wed, Oct 31, 2012 at 03:45:19PM -0200, Luiz Capitulino wrote: > > This commit prepares ga_channel_new(), ga_channel_read() and > > ga_channel_open() for isa-serial support. > > > > Signed-off-by: Luiz Capitulino > > Reviewed-by: Michae

Re: [Qemu-devel] [PATCH 4/5] qemu-ga: win32: isolate virtio-serial specific code

2012-11-01 Thread Michael Roth
On Wed, Oct 31, 2012 at 03:45:19PM -0200, Luiz Capitulino wrote: > This commit prepares ga_channel_new(), ga_channel_read() and > ga_channel_open() for isa-serial support. > > Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Though I'm wondering if it'd be nicer to: 1) Add a GAChanne

[Qemu-devel] [PATCH 4/5] qemu-ga: win32: isolate virtio-serial specific code

2012-10-31 Thread Luiz Capitulino
This commit prepares ga_channel_new(), ga_channel_read() and ga_channel_open() for isa-serial support. Signed-off-by: Luiz Capitulino --- qga/channel-win32.c | 75 ++--- 1 file changed, 42 insertions(+), 33 deletions(-) diff --git a/qga/channel-wi