Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-12 Thread P J P
+-- On Wed, 12 Dec 2018, Yuval Shaia wrote --+ | Can you try master? | I just did a rebase on top of master and had no conflicts. Yes, I tried with master first, got the same errors, that's when I tried earlier versions. Preparing patch-set v2 with the suggested updates. Thank you. -- Prasad

Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-12 Thread Yuval Shaia
On Wed, Dec 12, 2018 at 03:09:19PM +0530, P J P wrote: > +-- On Wed, 12 Dec 2018, P J P wrote --+ > | | Also, can you rebase this patch on top of the patchset i posted last week: > | | https://patchwork.kernel.org/patch/10705439/ > | > | Okay, I'll send revised patch set. Thanks so much for the pr

Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-12 Thread Yuval Shaia
On Wed, Dec 12, 2018 at 03:09:19PM +0530, P J P wrote: > +-- On Wed, 12 Dec 2018, P J P wrote --+ > | | Also, can you rebase this patch on top of the patchset i posted last week: > | | https://patchwork.kernel.org/patch/10705439/ > | > | Okay, I'll send revised patch set. Thanks so much for the pr

Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-12 Thread P J P
+-- On Wed, 12 Dec 2018, P J P wrote --+ | | Also, can you rebase this patch on top of the patchset i posted last week: | | https://patchwork.kernel.org/patch/10705439/ | | Okay, I'll send revised patch set. Thanks so much for the prompt review. I tried to git apply above patch-set over v3.1.0-rc

Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-11 Thread P J P
Hello Yuval, +-- On Tue, 11 Dec 2018, Yuval Shaia wrote --+ | > Ditto, here send rind and recv rings stays mapped. | > Look at how QP's ring is destroyed in destroy_qp. | > | > For both case suggesting to define a new static function that destroy rings | > and call it from both error flow of cr

Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-11 Thread Yuval Shaia
On Tue, Dec 11, 2018 at 06:47:43PM +0200, Yuval Shaia wrote: > On Tue, Dec 11, 2018 at 06:56:41PM +0530, P J P wrote: > > From: Prasad J Pandit > > > > create_cq and create_qp routines allocate ring object, but it's > > not released in case of an error, leading to memory leakage. > > > > Reporte

Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-11 Thread Yuval Shaia
On Tue, Dec 11, 2018 at 06:56:41PM +0530, P J P wrote: > From: Prasad J Pandit > > create_cq and create_qp routines allocate ring object, but it's > not released in case of an error, leading to memory leakage. > > Reported-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/rdma/vmw/pvrd

[Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-11 Thread P J P
From: Prasad J Pandit create_cq and create_qp routines allocate ring object, but it's not released in case of an error, leading to memory leakage. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/rdma/vmw/pvrdma_cmd.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) di