Re: [Qemu-devel] [PATCH 4/5] net: add offloadings support to netmap backend

2014-01-13 Thread Stefan Hajnoczi
On Mon, Jan 13, 2014 at 04:11:25PM +0100, Vincenzo Maffione wrote: > 2014/1/13 Stefan Hajnoczi > > > On Fri, Dec 13, 2013 at 01:05:02PM +0100, Vincenzo Maffione wrote: > > > +static void netmap_using_vnet_hdr(NetClientState *nc, bool enable) > > > +{ > > > +} > > > > I was trying to figure out wh

Re: [Qemu-devel] [PATCH 4/5] net: add offloadings support to netmap backend

2014-01-13 Thread Vincenzo Maffione
2014/1/13 Stefan Hajnoczi > On Fri, Dec 13, 2013 at 01:05:02PM +0100, Vincenzo Maffione wrote: > > +static void netmap_using_vnet_hdr(NetClientState *nc, bool enable) > > +{ > > +} > > I was trying to figure out whether it's okay for this function to be a > nop. I've come to the conclusion that

Re: [Qemu-devel] [PATCH 4/5] net: add offloadings support to netmap backend

2014-01-12 Thread Stefan Hajnoczi
On Fri, Dec 13, 2013 at 01:05:02PM +0100, Vincenzo Maffione wrote: > +static void netmap_using_vnet_hdr(NetClientState *nc, bool enable) > +{ > +} I was trying to figure out whether it's okay for this function to be a nop. I've come to the conclusion that it's okay: If the netdev supports vnet_h

[Qemu-devel] [PATCH 4/5] net: add offloadings support to netmap backend

2013-12-13 Thread Vincenzo Maffione
Whit this patch, the netmap backend supports TSO/UFO/CSUM offloadings, and accepts the virtio-net header, similarly to what happens with TAP. The offloading callbacks in the NetClientInfo interface have been implemented. Signed-off-by: Vincenzo Maffione --- net/netmap.c | 64