Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

2009-12-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 15 Dec 2009 10:54:23 +0100 > Markus Armbruster wrote: > >> Markus Armbruster writes: >> >> > Luiz Capitulino writes: >> > >> >> The monitor_read_command() function is readline specific >> >> and should only be used when readline is available. >> >> >> >> Sign

Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

2009-12-15 Thread Luiz Capitulino
On Tue, 15 Dec 2009 10:54:23 +0100 Markus Armbruster wrote: > Markus Armbruster writes: > > > Luiz Capitulino writes: > > > >> The monitor_read_command() function is readline specific > >> and should only be used when readline is available. > >> > >> Signed-off-by: Luiz Capitulino > > > > I f

Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

2009-12-15 Thread Markus Armbruster
Markus Armbruster writes: > Luiz Capitulino writes: > >> The monitor_read_command() function is readline specific >> and should only be used when readline is available. >> >> Signed-off-by: Luiz Capitulino > > I figure this bug breaks password entry (VNC and block) on non-readline > monitors.

Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

2009-12-15 Thread Markus Armbruster
Luiz Capitulino writes: > The monitor_read_command() function is readline specific > and should only be used when readline is available. > > Signed-off-by: Luiz Capitulino I figure this bug breaks password entry (VNC and block) on non-readline monitors. Suspect commit cde76ee1.

[Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

2009-12-14 Thread Luiz Capitulino
The monitor_read_command() function is readline specific and should only be used when readline is available. Signed-off-by: Luiz Capitulino --- monitor.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 920ccff..b518cc4 100644 --- a/monitor.c