Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

2016-01-18 Thread John Snow
On 01/18/2016 09:29 AM, Kevin Wolf wrote: > Am 12.01.2016 um 19:02 hat John Snow geschrieben: >> >> >> On 01/12/2016 01:01 PM, Paolo Bonzini wrote: >>> >>> >>> On 12/01/2016 18:57, John Snow wrote: On 01/12/2016 03:46 AM, Paolo Bonzini wrote: > > > On 12/01/2016 01:36,

Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

2016-01-18 Thread Kevin Wolf
Am 12.01.2016 um 19:02 hat John Snow geschrieben: > > > On 01/12/2016 01:01 PM, Paolo Bonzini wrote: > > > > > > On 12/01/2016 18:57, John Snow wrote: > >> > >> > >> On 01/12/2016 03:46 AM, Paolo Bonzini wrote: > >>> > >>> > >>> On 12/01/2016 01:36, John Snow wrote: > Instead of relying on

Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

2016-01-12 Thread John Snow
On 01/12/2016 01:01 PM, Paolo Bonzini wrote: > > > On 12/01/2016 18:57, John Snow wrote: >> >> >> On 01/12/2016 03:46 AM, Paolo Bonzini wrote: >>> >>> >>> On 12/01/2016 01:36, John Snow wrote: Instead of relying on peeking at bs->job, we want to explicitly get a reference to the job t

Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

2016-01-12 Thread Paolo Bonzini
On 12/01/2016 18:57, John Snow wrote: > > > On 01/12/2016 03:46 AM, Paolo Bonzini wrote: >> >> >> On 12/01/2016 01:36, John Snow wrote: >>> Instead of relying on peeking at bs->job, we want to explicitly get >>> a reference to the job that was involved in this notifier callback. >>> >>> Extend

Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

2016-01-12 Thread John Snow
On 01/12/2016 03:46 AM, Paolo Bonzini wrote: > > > On 12/01/2016 01:36, John Snow wrote: >> Instead of relying on peeking at bs->job, we want to explicitly get >> a reference to the job that was involved in this notifier callback. >> >> Extend the Notifier to include a job pointer, and include

Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

2016-01-12 Thread Paolo Bonzini
On 12/01/2016 01:36, John Snow wrote: > Instead of relying on peeking at bs->job, we want to explicitly get > a reference to the job that was involved in this notifier callback. > > Extend the Notifier to include a job pointer, and include a reference > to the job registering the callback. This

[Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

2016-01-11 Thread John Snow
Instead of relying on peeking at bs->job, we want to explicitly get a reference to the job that was involved in this notifier callback. Extend the Notifier to include a job pointer, and include a reference to the job registering the callback. This cuts out a few more cases where we have to rely on