Re: [Qemu-devel] [PATCH 4/5] backup: simplify non-dirty bits progress processing

2017-10-12 Thread Eric Blake
On 10/12/2017 06:42 AM, Vladimir Sementsov-Ogievskiy wrote: >> I'm not sure we actually need a new field... let's just say that the job >> length is the number of bytes described by the incremental backup. Every >> time we copy some, move offset forward. This would give a more >> appropriately lin

[Qemu-devel] [PATCH 4/5] backup: simplify non-dirty bits progress processing

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Set fake progress for non-dirty clusters in copy_bitmap initialization, to. It simplifies code and allows further refactoring. This patch changes user's view of backup progress, but formally it doesn't changed: progress hops are just moved to the beginning. Actually it's just a point of view: whe

Re: [Qemu-devel] [PATCH 4/5] backup: simplify non-dirty bits progress processing

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
10.10.2017 02:44, John Snow wrote: On 10/02/2017 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: Set fake progress for non-dirty clusters in copy_bitmap initialization, to. It simplifies code and allows further refactoring. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Motivation (some of th

Re: [Qemu-devel] [PATCH 4/5] backup: simplify non-dirty bits progress processing

2017-10-09 Thread John Snow
On 10/02/2017 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: > Set fake progress for non-dirty clusters in copy_bitmap initialization, > to. It simplifies code and allows further refactoring. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Motivation (some of these paragraphs may be n