Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Orit Wasserman
On 01/30/2013 07:59 PM, Eric Blake wrote: > On 01/30/2013 03:35 AM, Orit Wasserman wrote: >> XBZRLE is not effective when migrating to file. > > Why not? When doing a live migration to file, the same sector of memory > can be visited more than once in the migration stream, and thus > compressing

Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Eric Blake
On 01/30/2013 03:35 AM, Orit Wasserman wrote: > XBZRLE is not effective when migrating to file. Why not? When doing a live migration to file, the same sector of memory can be visited more than once in the migration stream, and thus compressing the later pages should make the saved file smaller.

Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Orit Wasserman
On 01/30/2013 01:07 PM, Paolo Bonzini wrote: > >> On 01/30/2013 12:49 PM, Paolo Bonzini wrote: XBZRLE is not effective when migrating to file. Disabling it automatically will remove the need to update the command line to allow loading a guest from a file that was in XBZRLE

[Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Orit Wasserman
XBZRLE is not effective when migrating to file. Disabling it automatically will remove the need to update the command line to allow loading a guest from a file that was in XBZRLE format. Signed-off-by: Orit Wasserman --- include/migration/migration.h | 1 + migration-exec.c | 6 +++

Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Paolo Bonzini
> On 01/30/2013 12:49 PM, Paolo Bonzini wrote: > >> XBZRLE is not effective when migrating to file. > >> > >> Disabling it automatically will remove the need to update the > >> command line to allow loading a guest from a file that was in > >> XBZRLE format. > > > > What about savevm? > I think a

Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Orit Wasserman
On 01/30/2013 12:49 PM, Paolo Bonzini wrote: > >> XBZRLE is not effective when migrating to file. >> >> Disabling it automatically will remove the need to update the >> command line to allow loading a guest from a file that was in XBZRLE >> format. > > What about savevm? I think a user that activ

Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Paolo Bonzini
> XBZRLE is not effective when migrating to file. > > Disabling it automatically will remove the need to update the > command line to allow loading a guest from a file that was in XBZRLE > format. What about savevm? Paolo > Signed-off-by: Orit Wasserman > --- > include/migration/migration.h