Re: [Qemu-devel] [PATCH 4/5] ARM BE32 watchpoint fix.

2016-12-06 Thread Julian Brown
On Fri, 4 Nov 2016 09:55:17 +0100 Paolo Bonzini wrote: > On 04/11/2016 00:20, Julian Brown wrote: > > On Thu, 3 Nov 2016 23:14:05 + > > Peter Maydell wrote: > > > >> On 3 November 2016 at 17:30, Julian Brown > >> wrote: > >>> In BE32 mode, sub-word size watchpoints can fail to trigger

Re: [Qemu-devel] [PATCH 4/5] ARM BE32 watchpoint fix.

2016-11-04 Thread Paolo Bonzini
On 04/11/2016 00:20, Julian Brown wrote: > On Thu, 3 Nov 2016 23:14:05 + > Peter Maydell wrote: > >> On 3 November 2016 at 17:30, Julian Brown >> wrote: >>> In BE32 mode, sub-word size watchpoints can fail to trigger because >>> the address of the access is adjusted in the opcode helpers b

Re: [Qemu-devel] [PATCH 4/5] ARM BE32 watchpoint fix.

2016-11-03 Thread Julian Brown
On Thu, 3 Nov 2016 23:14:05 + Peter Maydell wrote: > On 3 November 2016 at 17:30, Julian Brown > wrote: > > In BE32 mode, sub-word size watchpoints can fail to trigger because > > the address of the access is adjusted in the opcode helpers before > > being compared with the watchpoint regist

Re: [Qemu-devel] [PATCH 4/5] ARM BE32 watchpoint fix.

2016-11-03 Thread Peter Maydell
On 3 November 2016 at 17:30, Julian Brown wrote: > In BE32 mode, sub-word size watchpoints can fail to trigger because the > address of the access is adjusted in the opcode helpers before being > compared with the watchpoint registers. This patch reversed the address > adjustment before performin

[Qemu-devel] [PATCH 4/5] ARM BE32 watchpoint fix.

2016-11-03 Thread Julian Brown
In BE32 mode, sub-word size watchpoints can fail to trigger because the address of the access is adjusted in the opcode helpers before being compared with the watchpoint registers. This patch reversed the address adjustment before performing the comparison. Signed-off-by: Julian Brown --- exec.