Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-08 Thread Kashyap Chamarthy
On Fri, May 05, 2017 at 02:59:24PM -0300, Eduardo Habkost wrote: > On Thu, May 04, 2017 at 12:16:38PM +0200, Kashyap Chamarthy wrote: > > On Tue, May 02, 2017 at 05:31:15PM -0300, Eduardo Habkost wrote: > > > > Hi, > > > > Yet to try this series, a small question in-line. > > > > > Introduce a n

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-05 Thread Eduardo Habkost
On Thu, May 04, 2017 at 12:16:38PM +0200, Kashyap Chamarthy wrote: > On Tue, May 02, 2017 at 05:31:15PM -0300, Eduardo Habkost wrote: > > Hi, > > Yet to try this series, a small question in-line. > > > Introduce a new CPUFeatureSetting QAPI data type, and use it to support > > feature=force on -

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-05 Thread Eduardo Habkost
On Thu, May 04, 2017 at 11:49:38AM +0200, Igor Mammedov wrote: > On Tue, 2 May 2017 17:31:15 -0300 > Eduardo Habkost wrote: > > > Introduce a new CPUFeatureSetting QAPI data type, and use it to support > > feature=force on -cpu. > commit message lacks rationale why it's needed. > I suspect that

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-04 Thread Kashyap Chamarthy
On Tue, May 02, 2017 at 05:31:15PM -0300, Eduardo Habkost wrote: Hi, Yet to try this series, a small question in-line. > Introduce a new CPUFeatureSetting QAPI data type, and use it to support > feature=force on -cpu. > > Signed-off-by: Eduardo Habkost > --- > qapi-schema.json |

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-04 Thread Igor Mammedov
On Tue, 2 May 2017 17:31:15 -0300 Eduardo Habkost wrote: > Introduce a new CPUFeatureSetting QAPI data type, and use it to support > feature=force on -cpu. commit message lacks rationale why it's needed. I suspect that it's to enable forced mwait. It would be nice to put here answer to what moti

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-02 Thread Eduardo Habkost
On Tue, May 02, 2017 at 04:42:02PM -0500, Eric Blake wrote: [...] > > -if (value) { > > -cpu->env.features[fp->w] |= fp->mask; > > -} else { > > -cpu->env.features[fp->w] &= ~fp->mask; > > +switch (value->type) { > > +case QTYPE_QBOOL: > > +if (value->u.q_boo

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-02 Thread Eric Blake
On 05/02/2017 03:31 PM, Eduardo Habkost wrote: > Introduce a new CPUFeatureSetting QAPI data type, and use it to support > feature=force on -cpu. > > Signed-off-by: Eduardo Habkost > --- > qapi-schema.json | 32 + > target/i386/cpu.h | 2 ++ > ta

[Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-02 Thread Eduardo Habkost
Introduce a new CPUFeatureSetting QAPI data type, and use it to support feature=force on -cpu. Signed-off-by: Eduardo Habkost --- qapi-schema.json | 32 + target/i386/cpu.h | 2 ++ target/i386/cpu.c | 55 ++