Re: [Qemu-devel] [PATCH 4/4] target-mips: Fix MIPS_DEBUG.

2011-12-31 Thread Richard Henderson
On 12/31/2011 10:50 PM, Peter Maydell wrote: >> +static void gen_logic_imm (CPUState *env, DisasContext *ctx, uint32_t opc, >> + int rt, int rs, int16_t imm) >> { >> target_ulong uimm; >> const char *opn = "imm logic"; > > Am I missing something, or does gen_logi

Re: [Qemu-devel] [PATCH 4/4] target-mips: Fix MIPS_DEBUG.

2011-12-31 Thread Andreas Färber
Am 31.12.2011 05:54, schrieb Richard Henderson: > The macro uses the DisasContext. Pass it around as needed. This fixes a build failure, right? Order it first then? Since there's no cover letter, series looks mostly good. Some minor comments. > > Signed-off-by: Richard Henderson > --- > targ

Re: [Qemu-devel] [PATCH 4/4] target-mips: Fix MIPS_DEBUG.

2011-12-31 Thread Peter Maydell
On 31 December 2011 04:54, Richard Henderson wrote: > The macro uses the DisasContext.  Pass it around as needed. > > Signed-off-by: Richard Henderson > --- >  target-mips/translate.c |   80 > ++- >  1 files changed, 44 insertions(+), 36 deletions(-) >

[Qemu-devel] [PATCH 4/4] target-mips: Fix MIPS_DEBUG.

2011-12-30 Thread Richard Henderson
The macro uses the DisasContext. Pass it around as needed. Signed-off-by: Richard Henderson --- target-mips/translate.c | 80 ++- 1 files changed, 44 insertions(+), 36 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c inde