Re: [Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga

2011-04-10 Thread Alon Levy
On Sun, Apr 10, 2011 at 09:37:12PM +1000, Brad Hards wrote: > On Sun, 10 Apr 2011 08:26:06 pm Alon Levy wrote: > > -if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT) > > +if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT > > +|| (io_port == QXL_IO_

Re: [Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga

2011-04-10 Thread Brad Hards
On Sun, 10 Apr 2011 08:26:06 pm Alon Levy wrote: > -if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT) > +if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT > +|| (io_port == QXL_IO_LOG)) I think this might look better with consistent use of brackets

[Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga

2011-04-10 Thread Alon Levy
The driver may change us to vga mode and still issue a QXL_IO_LOG, which we can easily support. --- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 86b98ee..4080325 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -943,7 +943,8 @@ static void io