Re: [Qemu-devel] [PATCH 4/4] nbd/client: Deal with unaligned size from server

2018-08-17 Thread Eric Blake
On 08/17/2018 08:57 AM, Vladimir Sementsov-Ogievskiy wrote: 02.08.2018 17:48, Eric Blake wrote: When a server advertises an unaligned size but no block sizes, the code was rounding up to a sector-aligned size (a known limitation of bdrv_getlength()), then assuming a request_alignment of 512 (the

Re: [Qemu-devel] [PATCH 4/4] nbd/client: Deal with unaligned size from server

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
02.08.2018 17:48, Eric Blake wrote: When a server advertises an unaligned size but no block sizes, the code was rounding up to a sector-aligned size (a known limitation of bdrv_getlength()), then assuming a request_alignment of 512 (the recommendation of the NBD spec for maximum portability). How

[Qemu-devel] [PATCH 4/4] nbd/client: Deal with unaligned size from server

2018-08-02 Thread Eric Blake
When a server advertises an unaligned size but no block sizes, the code was rounding up to a sector-aligned size (a known limitation of bdrv_getlength()), then assuming a request_alignment of 512 (the recommendation of the NBD spec for maximum portability). However, this means that qemu will actual