Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-06 Thread Aleksandar Markovic
5:38 AM To: Aleksandar Markovic Cc: Aleksandar Markovic; Riku Voipio; QEMU Developers; Laurent Vivier; Miodrag Dinic; Aleksandar Rikalo; Petar Jovanovic; Yongbok Kim; Leon Alrae; Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32 On 5

Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-05 Thread Peter Maydell
On 5 October 2016 at 03:02, Aleksandar Markovic wrote: > Yes, we could replace TARGET_NR_fadvise64 with TARGET_NR_fadvise64_64 > in Mips32 syscall numbers definition list, and expect the same effect. > I just prefer to leave original symbols for syscall numbers, as they > are defined in kernel he

Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-05 Thread Aleksandar Markovic
Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32 Hi, Peter, The file in question is arch/mips/kernel/scall32-o32.S. I'll correct this in next version. Thank for the reviewing this patch. I am going to answer your second question tomorrow. The quick answer

Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-04 Thread Aleksandar Markovic
Hi, Peter, The file in question is arch/mips/kernel/scall32-o32.S. I'll correct this in next version. Thank for the reviewing this patch. I am going to answer your second question tomorrow. The quick answer is actually yes, but there are caveats, that I will explain tomorrow. Respectfully, Ale

Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-04 Thread Peter Maydell
On 4 October 2016 at 11:05, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > By looking at the file arch/mips/kernel/sys.S in Linux kernel, There doesn't appear to be a file by that name: http://lxr.free-electrons.com/source/arch/mips/kernel/ > it can be deduced that, for Mips32 platf

[Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-04 Thread Aleksandar Markovic
From: Aleksandar Markovic By looking at the file arch/mips/kernel/sys.S in Linux kernel, it can be deduced that, for Mips32 platform, syscall corresponding to number _NR_fadvise64 translates to kernel function sys_fadvise64_64, and that argument layout is as follows: 0 32 0