Re: [Qemu-devel] [PATCH 4/4] kvm: support MSI_X2APIC capability

2016-05-17 Thread Paolo Bonzini
On 06/05/2016 22:53, Radim Krčmář wrote: > +route->kroute.type = kvm_has_msi_x2apic() ? > KVM_IRQ_ROUTING_MSI_X2APIC > + : KVM_IRQ_ROUTING_MSI; > route->kroute.flags = 0; Perhaps using flags here instead of a new route type gives

Re: [Qemu-devel] [PATCH 4/4] kvm: support MSI_X2APIC capability

2016-05-09 Thread Radim Krčmář
2016-05-07 16:03+0200, Jan Kiszka: > On 2016-05-06 22:53, Radim Krčmář wrote: >> The capability alows us to express x2APIC destinations. > > "allows" Thanks. :) > Will the possibility to create >254 CPUs be indirectly coupled to this > capability, or should userland check for it explicitly then?

Re: [Qemu-devel] [PATCH 4/4] kvm: support MSI_X2APIC capability

2016-05-07 Thread Jan Kiszka
On 2016-05-06 22:53, Radim Krčmář wrote: > The capability alows us to express x2APIC destinations. "allows" Will the possibility to create >254 CPUs be indirectly coupled to this capability, or should userland check for it explicitly then? Will the kernel handle the case gracefully that AMD CPUs

[Qemu-devel] [PATCH 4/4] kvm: support MSI_X2APIC capability

2016-05-06 Thread Radim Krčmář
The capability alows us to express x2APIC destinations. Signed-off-by: Radim Krčmář --- include/sysemu/kvm.h | 1 + kvm-all.c| 14 +- target-i386/kvm.c| 4 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.