Re: [Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function

2016-05-20 Thread Bandan Das
Paolo Bonzini writes: > On 20/05/2016 00:15, Bandan Das wrote: >> void qmp_inject_nmi(Error **errp) >> { >> -#if defined(TARGET_I386) >> -CPUState *cs; >> - >> -CPU_FOREACH(cs) { >> -X86CPU *cpu = X86_CPU(cs); >> - >> -if (!cpu->apic_state) { >> -cpu_interrup

Re: [Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function

2016-05-20 Thread Paolo Bonzini
On 20/05/2016 00:15, Bandan Das wrote: > void qmp_inject_nmi(Error **errp) > { > -#if defined(TARGET_I386) > -CPUState *cs; > - > -CPU_FOREACH(cs) { > -X86CPU *cpu = X86_CPU(cs); > - > -if (!cpu->apic_state) { > -cpu_interrupt(cs, CPU_INTERRUPT_NMI); > -

Re: [Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function

2016-05-20 Thread Paolo Bonzini
On 20/05/2016 00:15, Bandan Das wrote: > void qmp_inject_nmi(Error **errp) > { > -#if defined(TARGET_I386) > -CPUState *cs; > - > -CPU_FOREACH(cs) { > -X86CPU *cpu = X86_CPU(cs); > - > -if (!cpu->apic_state) { > -cpu_interrupt(cs, CPU_INTERRUPT_NMI); > -

[Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function

2016-05-19 Thread Bandan Das
Now that the common functions are in place, we can call it instead of duplicating code. Signed-off-by: Bandan Das --- cpus.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/cpus.c b/cpus.c index eb34b4f..ead4e3f 100644 --- a/cpus.c +++ b/cpus.c @@ -1693,21 +1