Re: [Qemu-devel] [PATCH 31/46] Postcopy: Rework migration thread for postcopy mode

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 13:04, Dr. David Alan Gilbert ha scritto: >> You don't really need the "else" if you have a continue. However, do you >> need _any_ of the "else" and "continue"? Would the next iteration of the >> "while" loop do anything else but invoking qemu_savevm_state_iterate. > > Yes, I've d

Re: [Qemu-devel] [PATCH 31/46] Postcopy: Rework migration thread for postcopy mode

2014-08-28 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: Hi Paolo, Apologies, I realised I hadn't dug into this comment. > Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: > >From: "Dr. David Alan Gilbert" > > > >Switch to postcopy if: > > 1) There's still a significant amount to transfer >

Re: [Qemu-devel] [PATCH 31/46] Postcopy: Rework migration thread for postcopy mode

2014-07-05 Thread Paolo Bonzini
Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: From: "Dr. David Alan Gilbert" Switch to postcopy if: 1) There's still a significant amount to transfer 2) Postcopy is enabled 3) It's taken longer than the time set by the parameter. and change the cleanup at the end of mi

[Qemu-devel] [PATCH 31/46] Postcopy: Rework migration thread for postcopy mode

2014-07-04 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Switch to postcopy if: 1) There's still a significant amount to transfer 2) Postcopy is enabled 3) It's taken longer than the time set by the parameter. and change the cleanup at the end of migration to match. Signed-off-by: Dr. David Alan Gilbert --- m