Re: [Qemu-devel] [PATCH 31/35] cpu: Move icount_decr to CPUNegativeOffsetState

2019-03-28 Thread Richard Henderson
On 3/25/19 10:23 AM, Paolo Bonzini wrote: > I think you should, because moving it to obj-y would be a major headache > if we ever were to resurrect the multiarch patches by Peter C. > > That said, does cpu_neg really need env_neg and thus ArchCPU? Perhaps > you could: > > 1) define CPUTLB in ter

Re: [Qemu-devel] [PATCH 31/35] cpu: Move icount_decr to CPUNegativeOffsetState

2019-03-25 Thread Richard Henderson
On 3/25/19 10:23 AM, Paolo Bonzini wrote: >> RFC: I had problems with the build system moving qom/cpu.c >> from common-obj-y to obj-y. Then I tried just splitting out >> a piece of it, and ran into odder build system issues. Then >> I hacked Makefile.target in a way that doesn't look right, >> bu

Re: [Qemu-devel] [PATCH 31/35] cpu: Move icount_decr to CPUNegativeOffsetState

2019-03-25 Thread Paolo Bonzini
On 23/03/19 20:09, Richard Henderson wrote: > Amusingly, we had already ignored the comment to keep this > value at the end of CPUState. This restores the minimum > negative offset from TCG_AREG0 for code generation. > > This is slightly complicated for qom/cpu.c and tcg-all.c, > in that they are

[Qemu-devel] [PATCH 31/35] cpu: Move icount_decr to CPUNegativeOffsetState

2019-03-23 Thread Richard Henderson
Amusingly, we had already ignored the comment to keep this value at the end of CPUState. This restores the minimum negative offset from TCG_AREG0 for code generation. This is slightly complicated for qom/cpu.c and tcg-all.c, in that they are compiled once. This means we need an out of line helpe