Re: [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

2017-04-05 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > > Hi > > >> @@ -1191,19 +1204,18 @@ static bool get_queued_page(RAMState *rs, > >> MigrationState *ms, > >> * > >> * It should be empty at the end anyway, but in

Re: [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

2017-04-05 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Mar 31, 2017 at 04:25:56PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Thu, Mar 23, 2017 at 09:45:23PM +0100, Juan Quintela wrote: > > > > This are the last postcopy fields still at MigrationState. Once the

Re: [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

2017-04-04 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: Hi >> @@ -1191,19 +1204,18 @@ static bool get_queued_page(RAMState *rs, >> MigrationState *ms, >> * >> * It should be empty at the end anyway, but in error cases there may >> * xbe some left. >> - * >> - * @ms:

Re: [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

2017-04-01 Thread Peter Xu
On Fri, Mar 31, 2017 at 04:25:56PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Mar 23, 2017 at 09:45:23PM +0100, Juan Quintela wrote: > > > This are the last postcopy fields still at MigrationState. Once there > > > > s/This/These/ > > > > > Move Migr

Re: [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

2017-03-31 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This are the last postcopy fields still at MigrationState. Once there > Move MigrationSrcPageRequest to ram.c and remove MigrationState > parameters where appropiate. > > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 17 +

Re: [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

2017-03-31 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Mar 23, 2017 at 09:45:23PM +0100, Juan Quintela wrote: > > This are the last postcopy fields still at MigrationState. Once there > > s/This/These/ > > > Move MigrationSrcPageRequest to ram.c and remove MigrationState > > parameters where appropiate

Re: [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

2017-03-30 Thread Juan Quintela
Peter Xu wrote: > On Thu, Mar 23, 2017 at 09:45:23PM +0100, Juan Quintela wrote: >> This are the last postcopy fields still at MigrationState. Once there > > s/This/These/ > >> Move MigrationSrcPageRequest to ram.c and remove MigrationState >> parameters where appropiate. >> >> Signed-off-by: Ju

Re: [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

2017-03-29 Thread Peter Xu
On Thu, Mar 23, 2017 at 09:45:23PM +0100, Juan Quintela wrote: > This are the last postcopy fields still at MigrationState. Once there s/This/These/ > Move MigrationSrcPageRequest to ram.c and remove MigrationState > parameters where appropiate. > > Signed-off-by: Juan Quintela Reviewed-by: P

[Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

2017-03-23 Thread Juan Quintela
This are the last postcopy fields still at MigrationState. Once there Move MigrationSrcPageRequest to ram.c and remove MigrationState parameters where appropiate. Signed-off-by: Juan Quintela --- include/migration/migration.h | 17 +--- migration/migration.c | 5 +--- migration