We must not call virtio_blk_data_plane_notify if dataplane is
disabled: we would hit a segmentation fault in notify_guest_bh as
s->guest_notifier has not been setup and is NULL.
Reviewed-by: Cornelia Huck
Signed-off-by: Paolo Bonzini
---
hw/block/dataplane/virtio-blk.c | 7 +++
hw/block/vir
On 31/03/2016 10:32, tu bo wrote:
>>
>> diff --git a/include/hw/virtio/virtio-blk.h
>> b/include/hw/virtio/virtio-blk.h
>> index 5cb66cd..073c632 100644
>> --- a/include/hw/virtio/virtio-blk.h
>> +++ b/include/hw/virtio/virtio-blk.h
>> @@ -53,6 +53,7 @@ typedef struct VirtIOBlock {
>> unsig
Hi Paolo:
On 03/30/2016 08:48 PM, Paolo Bonzini wrote:
The missing check on dataplane_disabled caused a segmentation
fault in notify_guest_bh, because s->guest_notifier was NULL.
Signed-off-by: Paolo Bonzini
---
hw/block/dataplane/virtio-blk.c | 7 +++
hw/block/virtio-blk.c |
On Wed, 30 Mar 2016 14:48:02 +0200
Paolo Bonzini wrote:
> The missing check on dataplane_disabled caused a segmentation
> fault in notify_guest_bh, because s->guest_notifier was NULL.
I think this patch description could be improved :)
"We must not call virtio_blk_data_plane_notify if dataplane
The missing check on dataplane_disabled caused a segmentation
fault in notify_guest_bh, because s->guest_notifier was NULL.
Signed-off-by: Paolo Bonzini
---
hw/block/dataplane/virtio-blk.c | 7 +++
hw/block/virtio-blk.c | 2 +-
include/hw/virtio/virtio-blk.h | 1 +
3 files changed
