Re: [Qemu-devel] [PATCH 3/9] iotests: Use Python byte strings where appropriate

2018-10-19 Thread Max Reitz
On 15.10.18 21:53, Eduardo Habkost wrote: > On Mon, Oct 15, 2018 at 04:14:47PM +0200, Max Reitz wrote: >> Since byte strings are no longer the default in Python 3, we have to >> explicitly use them where we need to, which is mostly when working with >> structures. It also means that we need to ope

Re: [Qemu-devel] [PATCH 3/9] iotests: Use Python byte strings where appropriate

2018-10-15 Thread Philippe Mathieu-Daudé
On 15/10/2018 16:14, Max Reitz wrote: > Since byte strings are no longer the default in Python 3, we have to > explicitly use them where we need to, which is mostly when working with > structures. It also means that we need to open a file in binary mode > when we want to use structures. > > On th

Re: [Qemu-devel] [PATCH 3/9] iotests: Use Python byte strings where appropriate

2018-10-15 Thread Eduardo Habkost
On Mon, Oct 15, 2018 at 04:14:47PM +0200, Max Reitz wrote: > Since byte strings are no longer the default in Python 3, we have to > explicitly use them where we need to, which is mostly when working with > structures. It also means that we need to open a file in binary mode > when we want to use s

[Qemu-devel] [PATCH 3/9] iotests: Use Python byte strings where appropriate

2018-10-15 Thread Max Reitz
Since byte strings are no longer the default in Python 3, we have to explicitly use them where we need to, which is mostly when working with structures. It also means that we need to open a file in binary mode when we want to use structures. On the other hand, we have to accomodate for the fact t