Re: [Qemu-devel] [PATCH 3/8] Sort RAMBlocks by ID for migration, not by ram_addr

2011-12-21 Thread Avi Kivity
On 12/21/2011 03:55 PM, Anthony Liguori wrote: > On 12/21/2011 07:34 AM, Avi Kivity wrote: >> ram_addr is (a) unstable (b) going away. Sort by idstr instead. >> >> Signed-off-by: Avi Kivity > > I don't see this as a problem, per say, but this is a significant > behavioral change. ram_addr does co

[Qemu-devel] [PATCH 3/8] Sort RAMBlocks by ID for migration, not by ram_addr

2011-12-21 Thread Avi Kivity
ram_addr is (a) unstable (b) going away. Sort by idstr instead. Signed-off-by: Avi Kivity --- arch_init.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 2743bfd..8a3f052 100644 --- a/arch_init.c +++ b/arch_init.c @@ -217,12 +217,8

Re: [Qemu-devel] [PATCH 3/8] Sort RAMBlocks by ID for migration, not by ram_addr

2011-12-21 Thread Anthony Liguori
On 12/21/2011 07:34 AM, Avi Kivity wrote: ram_addr is (a) unstable (b) going away. Sort by idstr instead. Signed-off-by: Avi Kivity I don't see this as a problem, per say, but this is a significant behavioral change. ram_addr does correspond roughly to the location in memory and historical