Hi Alex,
there was one leftover ...
On Mon, 2012-07-30 at 14:38 +0200, Alexander Graf wrote:
> On 24.07.2012, at 09:37, Christian Borntraeger wrote:
>
> > From: Heinz Graalfs
> >
> > This adds a more generic infrastructure for handling Service-Call
> > requests on s390. Currently we only supp
Am 24.07.2012 09:37, schrieb Christian Borntraeger:
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> new file mode 100644
> index 000..4095ba6
> --- /dev/null
> +++ b/hw/s390x/sclp.c
[...]
> +
> +static TypeInfo s390_sclp_bridge_info = {
Two minor comments:
static const please.
> +.nam
On 30/07/12 14:38, Alexander Graf wrote:
>> +/* There is one SCLP bus per machine */
>> +static SCLPS390Bus *sbus;
>
> ... but there isn't necessarily one machine per qemu instance. Today there
> is,
> but we shouldn't rely on that fact. Please move the bus variable into a
> machine
> struct t
On 24.07.2012, at 09:37, Christian Borntraeger wrote:
> From: Heinz Graalfs
>
> This adds a more generic infrastructure for handling Service-Call
> requests on s390. Currently we only support a small subset of Read
> SCP Info directly in target-s390x. This patch provides the base
> infrastructu
From: Heinz Graalfs
This adds a more generic infrastructure for handling Service-Call
requests on s390. Currently we only support a small subset of Read
SCP Info directly in target-s390x. This patch provides the base
infrastructure for supporting more commands and moves Read SCP
Info.
In the futu
