Re: [Qemu-devel] [PATCH 3/7] qdev_prop_parse(): report errors via Error

2013-02-05 Thread Laszlo Ersek
On 02/05/13 13:20, Luiz Capitulino wrote: > On Tue, 05 Feb 2013 01:31:14 +0100 > Laszlo Ersek wrote: > >> On 02/04/13 18:27, Luiz Capitulino wrote: >>> >>> I usually split this kind of patch the following way: >>> >>> 1. add an Error ** argument to the function reporting the error. Callers >>>

Re: [Qemu-devel] [PATCH 3/7] qdev_prop_parse(): report errors via Error

2013-02-05 Thread Luiz Capitulino
On Tue, 05 Feb 2013 01:31:14 +0100 Laszlo Ersek wrote: > On 02/04/13 18:27, Luiz Capitulino wrote: > > On Fri, 1 Feb 2013 18:38:15 +0100 > > Laszlo Ersek wrote: > > > >> > >> Signed-off-by: Laszlo Ersek > > > > I usually split this kind of patch the following way: > > > > 1. add an Error *

Re: [Qemu-devel] [PATCH 3/7] qdev_prop_parse(): report errors via Error

2013-02-04 Thread Laszlo Ersek
On 02/04/13 18:27, Luiz Capitulino wrote: > On Fri, 1 Feb 2013 18:38:15 +0100 > Laszlo Ersek wrote: > >> >> Signed-off-by: Laszlo Ersek > > I usually split this kind of patch the following way: > > 1. add an Error ** argument to the function reporting the error. Callers > are changed to

Re: [Qemu-devel] [PATCH 3/7] qdev_prop_parse(): report errors via Error

2013-02-04 Thread Luiz Capitulino
On Fri, 1 Feb 2013 18:38:15 +0100 Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek I usually split this kind of patch the following way: 1. add an Error ** argument to the function reporting the error. Callers are changed to pass NULL for the new argument 2. Handling of the new err

[Qemu-devel] [PATCH 3/7] qdev_prop_parse(): report errors via Error

2013-02-01 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/qdev-properties.h |4 +++- hw/qdev-monitor.c| 26 +- hw/qdev-properties.c | 12 3 files changed, 32 insertions(+), 10 deletions(-) diff --git a/hw/qdev-properties.h b/hw/qdev-properties.h index ddcf774..e33f31b