Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash

2019-04-30 Thread Alex Bennée
Thomas Huth writes: > bash is installed in a different directory on non-Linux systems like > FreeBSD. Do not hard-code /bin/bash here so that the tests can run > there, too. > > Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée > --- > tests/qemu-iotests/239 | 2 +- > tests/qemu-iotests/

Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash

2019-04-25 Thread Thomas Huth
On 24/04/2019 17.23, Daniel P. Berrangé wrote: > On Wed, Apr 24, 2019 at 09:14:29AM -0500, Eric Blake wrote: >> On 4/24/19 5:37 AM, Thomas Huth wrote: >>> bash is installed in a different directory on non-Linux systems like >>> FreeBSD. Do not hard-code /bin/bash here so that the tests can run >>>

Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash

2019-04-24 Thread Daniel P . Berrangé
On Wed, Apr 24, 2019 at 09:14:29AM -0500, Eric Blake wrote: > On 4/24/19 5:37 AM, Thomas Huth wrote: > > bash is installed in a different directory on non-Linux systems like > > FreeBSD. Do not hard-code /bin/bash here so that the tests can run > > there, too. > > These tests were obviously copy-a

Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash

2019-04-24 Thread Philippe Mathieu-Daudé
On 4/24/19 4:14 PM, Eric Blake wrote: > On 4/24/19 5:37 AM, Thomas Huth wrote: >> bash is installed in a different directory on non-Linux systems like >> FreeBSD. Do not hard-code /bin/bash here so that the tests can run >> there, too. > > These tests were obviously copy-and-pasted from a fork poi

Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash

2019-04-24 Thread Eric Blake
On 4/24/19 5:37 AM, Thomas Huth wrote: > bash is installed in a different directory on non-Linux systems like > FreeBSD. Do not hard-code /bin/bash here so that the tests can run > there, too. These tests were obviously copy-and-pasted from a fork point prior to commit 11a82d14. Reviewed-by: Eric

[Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash

2019-04-24 Thread Thomas Huth
bash is installed in a different directory on non-Linux systems like FreeBSD. Do not hard-code /bin/bash here so that the tests can run there, too. Signed-off-by: Thomas Huth --- tests/qemu-iotests/239 | 2 +- tests/qemu-iotests/240 | 2 +- tests/qemu-iotests/241 | 2 +- tests/qemu-iotests/243 |