Re: [Qemu-devel] [PATCH 3/6] spapr: fix error reporting in xics_system_init()

2017-05-15 Thread David Gibson
On Mon, May 15, 2017 at 01:39:36PM +0200, Greg Kurz wrote: > The xics_system_init() function passes its errp argument to xics_kvm_init(). > If the call fails and the user requested in-kernel irqchip, it then ends up > passing a NULL Error * to error_reportf_err() and the error message is > silently

Re: [Qemu-devel] [PATCH 3/6] spapr: fix error reporting in xics_system_init()

2017-05-15 Thread Cédric Le Goater
On 05/15/2017 01:39 PM, Greg Kurz wrote: > The xics_system_init() function passes its errp argument to xics_kvm_init(). > If the call fails and the user requested in-kernel irqchip, it then ends up > passing a NULL Error * to error_reportf_err() and the error message is > silently dropped. > > Pas

[Qemu-devel] [PATCH 3/6] spapr: fix error reporting in xics_system_init()

2017-05-15 Thread Greg Kurz
The xics_system_init() function passes its errp argument to xics_kvm_init(). If the call fails and the user requested in-kernel irqchip, it then ends up passing a NULL Error * to error_reportf_err() and the error message is silently dropped. Passing an errp argument is generally wrong, unless you