Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Michael R. Hines
On 06/28/2013 10:07 AM, Peter Maydell wrote: On 28 June 2013 15:00, Michael R. Hines wrote: On 06/28/2013 09:28 AM, Peter Maydell wrote: Is endianess for the data a big issue when you are assume the migration is happening across identical CPU architectures? Well: * is that a reasonable ass

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Michael R. Hines
On 06/28/2013 03:33 AM, Paolo Bonzini wrote: Il 28/06/2013 00:44, mrhi...@linux.vnet.ibm.com ha scritto: + * + * This will have a terrible impact on migration performance, so until future + * workload information or LRU information is available, do not attempt to use + * this feature except for

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Michael R. Hines
On 06/28/2013 09:28 AM, Peter Maydell wrote: On 28 June 2013 14:23, Michael R. Hines wrote: I assume from the PACKED annotations (do we really need both, incidentally) that this is shared with either the guest or with another instance of QEMU. Are there definitely no endianness issues to deal w

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Peter Maydell
On 28 June 2013 15:00, Michael R. Hines wrote: > On 06/28/2013 09:28 AM, Peter Maydell wrote: >>> Is endianess for the data a big issue when you are assume the migration >>> is happening across identical CPU architectures? >> >> Well: >> * is that a reasonable assumption? (why?) > > > I would ye

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Peter Maydell
On 28 June 2013 14:23, Michael R. Hines wrote: >> I assume from the PACKED annotations (do we really need both, >> incidentally) that this is shared with either the guest or >> with another instance of QEMU. Are there definitely no >> endianness issues to deal with here? > > > I have ntohl()/htonl

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Michael R. Hines
On 06/27/2013 07:16 PM, Peter Maydell wrote: On 27 June 2013 23:44, wrote: +if test "$rdma" != "no" ; then + cat > $TMPC < +int main(void) { return 0; } +EOF + rdma_libs="-lrdmacm -libverbs" + if compile_prog "-Werror" "$rdma_libs" ; then Do you really need -Werror in your test's CFLAGS? I

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Paolo Bonzini
Il 28/06/2013 00:44, mrhi...@linux.vnet.ibm.com ha scritto: > + * > + * This will have a terrible impact on migration performance, so until future > + * workload information or LRU information is available, do not attempt to > use > + * this feature except for basic testing. > + */ > +//#define RD

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-27 Thread Peter Maydell
On 27 June 2013 23:44, wrote: > +if test "$rdma" != "no" ; then > + cat > $TMPC < +#include > +int main(void) { return 0; } > +EOF > + rdma_libs="-lrdmacm -libverbs" > + if compile_prog "-Werror" "$rdma_libs" ; then Do you really need -Werror in your test's CFLAGS? If so, you need a comment