Re: [Qemu-devel] [PATCH 3/6] luks: Support .bdrv_co_create

2018-03-12 Thread Eric Blake
On 03/12/2018 06:47 AM, Kevin Wolf wrote: +## +{ 'struct': 'BlockdevCreateOptionsLUKS', + 'data': { 'file': 'BlockdevRef', +'qcrypto': 'QCryptoBlockCreateOptionsLUKS', +'size': 'size' } } s/qcrypto/crypto/ in this field. I do wonder ab

Re: [Qemu-devel] [PATCH 3/6] luks: Support .bdrv_co_create

2018-03-12 Thread Kevin Wolf
Am 12.03.2018 um 12:50 hat Daniel P. Berrangé geschrieben: > On Mon, Mar 12, 2018 at 12:47:21PM +0100, Kevin Wolf wrote: > > Am 12.03.2018 um 12:40 hat Daniel P. Berrangé geschrieben: > > > On Fri, Mar 09, 2018 at 06:27:10PM +0100, Kevin Wolf wrote: > > > > This adds the .bdrv_co_create driver call

Re: [Qemu-devel] [PATCH 3/6] luks: Support .bdrv_co_create

2018-03-12 Thread Daniel P . Berrangé
On Mon, Mar 12, 2018 at 12:47:21PM +0100, Kevin Wolf wrote: > Am 12.03.2018 um 12:40 hat Daniel P. Berrangé geschrieben: > > On Fri, Mar 09, 2018 at 06:27:10PM +0100, Kevin Wolf wrote: > > > This adds the .bdrv_co_create driver callback to luks, which enables > > > image creation over QMP. > > > >

Re: [Qemu-devel] [PATCH 3/6] luks: Support .bdrv_co_create

2018-03-12 Thread Kevin Wolf
Am 12.03.2018 um 12:40 hat Daniel P. Berrangé geschrieben: > On Fri, Mar 09, 2018 at 06:27:10PM +0100, Kevin Wolf wrote: > > This adds the .bdrv_co_create driver callback to luks, which enables > > image creation over QMP. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-core.json | 17 +

Re: [Qemu-devel] [PATCH 3/6] luks: Support .bdrv_co_create

2018-03-12 Thread Daniel P . Berrangé
On Fri, Mar 09, 2018 at 06:27:10PM +0100, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to luks, which enables > image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 17 - > block/crypto.c | 34 +++

Re: [Qemu-devel] [PATCH 3/6] luks: Support .bdrv_co_create

2018-03-09 Thread Eric Blake
On 03/09/2018 11:27 AM, Kevin Wolf wrote: This adds the .bdrv_co_create driver callback to luks, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 17 - block/crypto.c | 34 ++ 2 files changed, 5

[Qemu-devel] [PATCH 3/6] luks: Support .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to luks, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 17 - block/crypto.c | 34 ++ 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/qa