Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-13 Thread Eduardo Habkost
TL;DR: I still disagree about some points, but those points aren't so relevant anymore because I am starting to like having KVM-specific/TCG-specific subclasses (because of other problems that would be solved by them). On Wed, Feb 13, 2013 at 04:20:43PM +0100, Igor Mammedov wrote: [...] > > > >

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-13 Thread Igor Mammedov
On Tue, 12 Feb 2013 12:48:47 -0200 Eduardo Habkost wrote: > On Mon, Feb 11, 2013 at 02:52:49AM +0100, Igor Mammedov wrote: > > On Fri, 8 Feb 2013 16:13:02 -0200 > > Eduardo Habkost wrote: > > > > > On Fri, Feb 08, 2013 at 05:54:50PM +0100, Andreas Färber wrote: > > > > Am 08.02.2013 15:52, schr

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-12 Thread Eduardo Habkost
On Mon, Feb 11, 2013 at 02:52:49AM +0100, Igor Mammedov wrote: > On Fri, 8 Feb 2013 16:13:02 -0200 > Eduardo Habkost wrote: > > > On Fri, Feb 08, 2013 at 05:54:50PM +0100, Andreas Färber wrote: > > > Am 08.02.2013 15:52, schrieb Eduardo Habkost: > > > > On Fri, Feb 08, 2013 at 01:58:42PM +0100, I

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-10 Thread Igor Mammedov
On Fri, 8 Feb 2013 16:13:02 -0200 Eduardo Habkost wrote: > On Fri, Feb 08, 2013 at 05:54:50PM +0100, Andreas Färber wrote: > > Am 08.02.2013 15:52, schrieb Eduardo Habkost: > > > On Fri, Feb 08, 2013 at 01:58:42PM +0100, Igor Mammedov wrote: > > >> On Fri, 08 Feb 2013 12:16:17 +0100 > > >> Andrea

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 05:54:50PM +0100, Andreas Färber wrote: > Am 08.02.2013 15:52, schrieb Eduardo Habkost: > > On Fri, Feb 08, 2013 at 01:58:42PM +0100, Igor Mammedov wrote: > >> On Fri, 08 Feb 2013 12:16:17 +0100 > >> Andreas Färber wrote: > >>> Am 08.02.2013 10:03, schrieb Igor Mammedov: >

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Andreas Färber
Am 08.02.2013 15:52, schrieb Eduardo Habkost: > On Fri, Feb 08, 2013 at 01:58:42PM +0100, Igor Mammedov wrote: >> On Fri, 08 Feb 2013 12:16:17 +0100 >> Andreas Färber wrote: >>> Am 08.02.2013 10:03, schrieb Igor Mammedov: On Thu, 7 Feb 2013 13:08:19 -0200 Eduardo Habkost wrote: >>>

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 12:52:31PM -0200, Eduardo Habkost wrote: > On Fri, Feb 08, 2013 at 01:58:42PM +0100, Igor Mammedov wrote: [...] > > Continuing on theoretical issue: > > > We could add an inited field to X86CPUClass that gets checked at initfn > > > time (only ever getting set to true by the

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 01:58:42PM +0100, Igor Mammedov wrote: > On Fri, 08 Feb 2013 12:16:17 +0100 > Andreas Färber wrote: > > > Am 08.02.2013 10:03, schrieb Igor Mammedov: > > > On Thu, 7 Feb 2013 13:08:19 -0200 > > > Eduardo Habkost wrote: > > > > > >> On Tue, Feb 05, 2013 at 05:39:22PM +010

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Igor Mammedov
On Fri, 08 Feb 2013 12:16:17 +0100 Andreas Färber wrote: > Am 08.02.2013 10:03, schrieb Igor Mammedov: > > On Thu, 7 Feb 2013 13:08:19 -0200 > > Eduardo Habkost wrote: > > > >> On Tue, Feb 05, 2013 at 05:39:22PM +0100, Igor Mammedov wrote: > >>> From: Andreas Färber > >>> > >>> Move x86_def_t

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Andreas Färber
Am 08.02.2013 10:03, schrieb Igor Mammedov: > On Thu, 7 Feb 2013 13:08:19 -0200 > Eduardo Habkost wrote: > >> On Tue, Feb 05, 2013 at 05:39:22PM +0100, Igor Mammedov wrote: >>> From: Andreas Färber >>> >>> Move x86_def_t definition to header and embed into X86CPUClass. >>> Register types per bui

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Igor Mammedov
On Thu, 7 Feb 2013 13:08:19 -0200 Eduardo Habkost wrote: > On Tue, Feb 05, 2013 at 05:39:22PM +0100, Igor Mammedov wrote: > > From: Andreas Färber > > > > Move x86_def_t definition to header and embed into X86CPUClass. > > Register types per built-in model definition. > > > > Move version init

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 05:39:22PM +0100, Igor Mammedov wrote: > From: Andreas Färber > > Move x86_def_t definition to header and embed into X86CPUClass. > Register types per built-in model definition. > > Move version initialization from x86_cpudef_setup() to class_init. > > Inline cpu_x86_reg

[Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-05 Thread Igor Mammedov
From: Andreas Färber Move x86_def_t definition to header and embed into X86CPUClass. Register types per built-in model definition. Move version initialization from x86_cpudef_setup() to class_init. Inline cpu_x86_register() into the X86CPU initfn. Since instance_init cannot reports errors, drop