Re: [Qemu-devel] [PATCH 3/5] libcacard: initial commit after coding style fixes

2010-12-16 Thread Gerd Hoffmann
On 12/16/10 12:06, Alon Levy wrote: libcacard emulates a Common Access Card (CAC) which is a standard for smartcards. It is used by the emulated ccid card introduced in a following patch. Docs are available in docs/libcacard.txt Looks good to me, although I'm not a crypto expert. Most of the

Re: [Qemu-devel] [PATCH 3/5] libcacard: initial commit after coding style fixes

2010-12-15 Thread Gerd Hoffmann
On 12/12/10 19:37, Alon Levy wrote: From: Robert Relyea Signed-off-by: Alon Levy Commit message could be more verbose too. This is the smart card emulation library, right? Patch looks good on a quick glance, I'm not a crypto expert though. Acked-by: Gerd Hoffmann cheers, Gerd