Re: [Qemu-devel] [PATCH 3/5] block: make 'top' argument to block-commit optional

2014-05-15 Thread Eric Blake
On 05/14/2014 09:20 PM, Jeff Cody wrote: > Now that active layer block-commit is supported, the 'top' argument > no longer needs to be mandatory. > > Change it optional, with the default being the active layer in the > device chain. Good, this is an API-compatible change (doesn't break old client

Re: [Qemu-devel] [PATCH 3/5] block: make 'top' argument to block-commit optional

2014-05-15 Thread Jeff Cody
On Thu, May 15, 2014 at 01:47:55PM +0200, Benoît Canet wrote: > The Wednesday 14 May 2014 à 23:20:17 (-0400), Jeff Cody wrote : > > Now that active layer block-commit is supported, the 'top' argument > > no longer needs to be mandatory. > > > > Change it optional, with the default being the active

Re: [Qemu-devel] [PATCH 3/5] block: make 'top' argument to block-commit optional

2014-05-15 Thread Benoît Canet
The Wednesday 14 May 2014 à 23:20:17 (-0400), Jeff Cody wrote : > Now that active layer block-commit is supported, the 'top' argument > no longer needs to be mandatory. > > Change it optional, with the default being the active layer in the Do you mean "Change it to optional" or "Make it optional"

[Qemu-devel] [PATCH 3/5] block: make 'top' argument to block-commit optional

2014-05-14 Thread Jeff Cody
Now that active layer block-commit is supported, the 'top' argument no longer needs to be mandatory. Change it optional, with the default being the active layer in the device chain. Signed-off-by: Jeff Cody --- blockdev.c | 3 ++- qapi-schema.json | 7 --- qmp-commands.h