Re: [Qemu-devel] [PATCH 3/5] backup: init copy_bitmap from sync_bitmap for incremental

2017-11-06 Thread John Snow
On 10/12/2017 07:23 AM, Vladimir Sementsov-Ogievskiy wrote: > 10.10.2017 01:56, John Snow wrote: >> >> On 10/02/2017 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: >>> We should not copy non-dirty clusters in write notifiers. So, >>> initialize copy_bitmap from sync_bitmap. >>> >> ...! Duh, good f

[Qemu-devel] [PATCH 3/5] backup: init copy_bitmap from sync_bitmap for incremental

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
We should not copy non-dirty clusters in write notifiers. So, initialize copy_bitmap from sync_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/block/backup.c b/

Re: [Qemu-devel] [PATCH 3/5] backup: init copy_bitmap from sync_bitmap for incremental

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
10.10.2017 01:56, John Snow wrote: On 10/02/2017 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: We should not copy non-dirty clusters in write notifiers. So, initialize copy_bitmap from sync_bitmap. ...! Duh, good find!! So, previously we'd copy extra sectors if they just so happened to be wr

Re: [Qemu-devel] [PATCH 3/5] backup: init copy_bitmap from sync_bitmap for incremental

2017-10-09 Thread John Snow
On 10/02/2017 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: > We should not copy non-dirty clusters in write notifiers. So, > initialize copy_bitmap from sync_bitmap. > ...! Duh, good find!! So, previously we'd copy extra sectors if they just so happened to be written to during the backup proc