Re: [Qemu-devel] [PATCH 3/4 V3] Header with various utility functions shared

2012-07-09 Thread Deep Debroy
On Sun, Jul 8, 2012 at 11:57 PM, Paolo Bonzini wrote: > Il 07/07/2012 09:56, Blue Swirl ha scritto: >> These don't seem useful. I think DMA accessors should also be used. > > This is a paravirtualized device model, so I think no (like virtio). > > I agree that this patch can be dropped and the fun

Re: [Qemu-devel] [PATCH 3/4 V3] Header with various utility functions shared

2012-07-08 Thread Paolo Bonzini
Il 07/07/2012 09:56, Blue Swirl ha scritto: > These don't seem useful. I think DMA accessors should also be used. This is a paravirtualized device model, so I think no (like virtio). I agree that this patch can be dropped and the functions inlined manually in pvscsi.c (patch 4). Paolo

Re: [Qemu-devel] [PATCH 3/4 V3] Header with various utility functions shared

2012-07-07 Thread Blue Swirl
On Sat, Jul 7, 2012 at 5:05 AM, Deep Debroy wrote: > Signed-off-by: Deep Debroy > --- > hw/vmware_utils.h | 126 > + > 1 file changed, 126 insertions(+) > create mode 100644 hw/vmware_utils.h > > diff --git a/hw/vmware_utils.h b/hw/vmware_ut

[Qemu-devel] [PATCH 3/4 V3] Header with various utility functions shared

2012-07-06 Thread Deep Debroy
Signed-off-by: Deep Debroy --- hw/vmware_utils.h | 126 + 1 file changed, 126 insertions(+) create mode 100644 hw/vmware_utils.h diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h new file mode 100644 index 000..73b039e --- /dev/null +++