Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-17 Thread Michael S. Tsirkin
On Mon, Mar 17, 2014 at 02:36:37PM +1000, Dave Airlie wrote: > On Thu, Mar 13, 2014 at 8:40 PM, Paolo Bonzini wrote: > > Il 12/03/2014 21:26, Michael S. Tsirkin ha scritto: > >>> > >>> +Event queue: > >>> +The only current event passed is a message to denote the host > >>> +wants to update the lay

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-17 Thread Paolo Bonzini
Il 17/03/2014 06:21, Dave Airlie ha scritto: Oh I was also going to use this queue to report HW error events from the guest to the host, like if the guest tries an illegal operation, What fields would be present for such an error? Paolo

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-17 Thread Paolo Bonzini
Il 17/03/2014 05:36, Dave Airlie ha scritto: I steered away from using config space for anything for the normal operation of the GPU after looking at overheads and hearing from S390 people that config space has some special properties on their hw, Right, but this is only for the old s390-virtio

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-16 Thread Dave Airlie
On Mon, Mar 17, 2014 at 2:36 PM, Dave Airlie wrote: > On Thu, Mar 13, 2014 at 8:40 PM, Paolo Bonzini wrote: >> Il 12/03/2014 21:26, Michael S. Tsirkin ha scritto: +Event queue: +The only current event passed is a message to denote the host +wants to update the layout of the sc

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-16 Thread Dave Airlie
On Thu, Mar 13, 2014 at 8:40 PM, Paolo Bonzini wrote: > Il 12/03/2014 21:26, Michael S. Tsirkin ha scritto: >>> >>> +Event queue: >>> +The only current event passed is a message to denote the host >>> +wants to update the layout of the screens. It contains the same >>> +info as the response to VIR

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-16 Thread Michael S. Tsirkin
On Fri, Mar 14, 2014 at 12:18:38PM +0100, Gerd Hoffmann wrote: > Hi, > > > Perhaps a configuration field is better, like this: > > > > u32 events_read; > > u32 events_clear; > > > > A new event sets a bit in events_read and generates a configuration > > change interrupt. The guest

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-16 Thread Michael S. Tsirkin
On Fri, Mar 14, 2014 at 12:13:09PM +0100, Gerd Hoffmann wrote: > On Do, 2014-03-13 at 10:08 +0100, Gerd Hoffmann wrote: > > Hi, > > > > > One thing to do is add this to the virtio spec. > > > Need help with that? > > > > What is the authoritative spec these days? > > The virtio 1.0 draft? > > W

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-14 Thread Gerd Hoffmann
Hi, > Perhaps a configuration field is better, like this: > > u32 events_read; > u32 events_clear; > > A new event sets a bit in events_read and generates a configuration > change interrupt. The guest should never write to events_read. Makes sense to me. I think I'll go write up

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-14 Thread Gerd Hoffmann
On Do, 2014-03-13 at 10:08 +0100, Gerd Hoffmann wrote: > Hi, > > > One thing to do is add this to the virtio spec. > > Need help with that? > > What is the authoritative spec these days? > The virtio 1.0 draft? > Where can I find the latest revision? Seems to be this: https://github.com/rusty

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-13 Thread Paolo Bonzini
Il 12/03/2014 21:26, Michael S. Tsirkin ha scritto: +Event queue: +The only current event passed is a message to denote the host +wants to update the layout of the screens. It contains the same +info as the response to VIRTGPU_CMD_GET_DISPLAY_INFO. I wonder if an event queue is the best mechani

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-13 Thread Gerd Hoffmann
Hi, > One thing to do is add this to the virtio spec. > Need help with that? What is the authoritative spec these days? The virtio 1.0 draft? Where can I find the latest revision? Where should I send patches? > > docs/specs/virtio-gpu.txt | 89 + Some docs are here. cheers, G

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-12 Thread Michael S. Tsirkin
On Wed, Mar 12, 2014 at 01:55:13PM +0100, Gerd Hoffmann wrote: > From: Dave Airlie > > This is the basic virtio-gpu which is > > multi-head capable, > ARGB cursor support, > unaccelerated. > > Some more info is in docs/specs/virtio-gpu.txt. > > Signed-off-by: Dave Airlie > > changes by kraxe

[Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-12 Thread Gerd Hoffmann
From: Dave Airlie This is the basic virtio-gpu which is multi-head capable, ARGB cursor support, unaccelerated. Some more info is in docs/specs/virtio-gpu.txt. Signed-off-by: Dave Airlie changes by kraxel: * adapt to changes in master. * move from hw/virtio to hw/display. * codestyle clea