Re: [Qemu-devel] [PATCH 3/4] sdhci: Support SDHCI devices on PCI

2014-11-21 Thread Paolo Bonzini
On 21/11/2014 08:20, Gerd Hoffmann wrote: > Yes, for pci class devices (so the guest driver do not match specific > pci vendor/device ids, except for quirks) we started using the redhat > ids. > > > Gerd, you seem to > > be in charge of the redhat pci ids - are you okay if I us one (should > > i

Re: [Qemu-devel] [PATCH 3/4] sdhci: Support SDHCI devices on PCI

2014-11-20 Thread Gerd Hoffmann
Hi, > I know recent Intel chips (eg, baytrail) have a builtin sdhci > controller (eg, 8086:0f16). However, that has quirks defined in the > Linux driver. Basic functionality still does seem to work though when > I use those ids in qemu. The same basic functionality also seems to > work when I

Re: [Qemu-devel] [PATCH 3/4] sdhci: Support SDHCI devices on PCI

2014-11-20 Thread Kevin O'Connor
On Tue, Nov 18, 2014 at 07:27:24AM +0100, Paolo Bonzini wrote: > On 18/11/2014 05:26, Kevin O'Connor wrote: > > --- a/include/hw/pci/pci.h > > +++ b/include/hw/pci/pci.h > > @@ -53,6 +53,7 @@ > > /* QEMU/Bochs VGA (0x1234) */ > > #define PCI_VENDOR_ID_QEMU 0x1234 > > #define PCI_DE

Re: [Qemu-devel] [PATCH 3/4] sdhci: Support SDHCI devices on PCI

2014-11-17 Thread Paolo Bonzini
On 18/11/2014 05:26, Kevin O'Connor wrote: > Support for PCI devices following the "SD Host Controller Simplified > Specification Version 2.00" spec. > > Signed-off-by: Kevin O'Connor > --- > default-configs/pci.mak | 2 ++ > hw/sd/sdhci.c| 44 ++

[Qemu-devel] [PATCH 3/4] sdhci: Support SDHCI devices on PCI

2014-11-17 Thread Kevin O'Connor
Support for PCI devices following the "SD Host Controller Simplified Specification Version 2.00" spec. Signed-off-by: Kevin O'Connor --- default-configs/pci.mak | 2 ++ hw/sd/sdhci.c| 44 hw/sd/sdhci.h| 9 - include/