Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-29 Thread Paolo Bonzini
On 29/03/2017 17:29, Dr. David Alan Gilbert wrote: >>> 'abort' is not very good too I think. migration is completed, nothing to >>> abort.. (may be successful migration to file for suspend, some kind of >>> vm cloning, etc) >> There is already migrate_cancel. Does it make sense to make it >> rea

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-29 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 28/03/2017 15:16, Vladimir Sementsov-Ogievskiy wrote: > > 28.03.2017 15:09, Kevin Wolf wrote: > >> Am 28.03.2017 um 13:13 hat Dr. David Alan Gilbert geschrieben: > >>> * Kevin Wolf (kw...@redhat.com) wrote: > Am 28.03.2017 um 12:55 hat Dr

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-28 Thread Denis V. Lunev
On 03/28/2017 01:55 PM, Dr. David Alan Gilbert wrote: > * Kevin Wolf (kw...@redhat.com) wrote: >> Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> After migration all drives are inactive and savevm will fail with >>> >>> qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: >>>

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-28 Thread Paolo Bonzini
On 28/03/2017 15:16, Vladimir Sementsov-Ogievskiy wrote: > 28.03.2017 15:09, Kevin Wolf wrote: >> Am 28.03.2017 um 13:13 hat Dr. David Alan Gilbert geschrieben: >>> * Kevin Wolf (kw...@redhat.com) wrote: Am 28.03.2017 um 12:55 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-28 Thread Vladimir Sementsov-Ogievskiy
28.03.2017 15:09, Kevin Wolf wrote: Am 28.03.2017 um 13:13 hat Dr. David Alan Gilbert geschrieben: * Kevin Wolf (kw...@redhat.com) wrote: Am 28.03.2017 um 12:55 hat Dr. David Alan Gilbert geschrieben: * Kevin Wolf (kw...@redhat.com) wrote: Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievsk

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-28 Thread Kevin Wolf
Am 28.03.2017 um 13:13 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 28.03.2017 um 12:55 hat Dr. David Alan Gilbert geschrieben: > > > * Kevin Wolf (kw...@redhat.com) wrote: > > > > Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > > >

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-28 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 28.03.2017 um 12:55 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > > After migration all drives are inactive and savevm will fail with > >

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-28 Thread Kevin Wolf
Am 28.03.2017 um 12:55 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > After migration all drives are inactive and savevm will fail with > > > > > > qemu-kvm: block/io.c:1406: bdrv_co_do

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-28 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > > After migration all drives are inactive and savevm will fail with > > > > qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: > >Assertion `!(bs->open_flags & 0x0800)' failed. > > > >

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-07 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 07.03.2017 um 10:59 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 07.03.2017 12:53, Kevin Wolf wrote: > > >Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > > >>After migration all drives are inactive and savevm will fail with > >

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-07 Thread Kevin Wolf
Am 07.03.2017 um 10:59 hat Vladimir Sementsov-Ogievskiy geschrieben: > 07.03.2017 12:53, Kevin Wolf wrote: > >Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>After migration all drives are inactive and savevm will fail with > >> > >>qemu-kvm: block/io.c:1406: bdrv_co_do_pwr

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-07 Thread Vladimir Sementsov-Ogievskiy
07.03.2017 12:53, Kevin Wolf wrote: Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: After migration all drives are inactive and savevm will fail with qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed. Signed-off-by: Vladimir S

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-03-07 Thread Kevin Wolf
Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > After migration all drives are inactive and savevm will fail with > > qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: >Assertion `!(bs->open_flags & 0x0800)' failed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy What's

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-02-27 Thread Denis V. Lunev
On 02/25/2017 10:31 PM, Vladimir Sementsov-Ogievskiy wrote: > After migration all drives are inactive and savevm will fail with > > qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: >Assertion `!(bs->open_flags & 0x0800)' failed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/snap

[Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-02-25 Thread Vladimir Sementsov-Ogievskiy
After migration all drives are inactive and savevm will fail with qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/snapshot.c | 3 ++- migration/savevm.c | 11 +++ 2 files changed, 1