Re: [Qemu-devel] [PATCH 3/4] qobject: Parse non-finite numbers, as an extension

2016-06-17 Thread Markus Armbruster
Eric Blake writes: > On 06/16/2016 10:25 AM, Markus Armbruster wrote: >> I think this commit mixes up parsing of non-finite numbers, which we may >> or may not want, with general test improvements, which we'll want >> regardless. Please split the patch. >> >> On the parsing of non-finite number

Re: [Qemu-devel] [PATCH 3/4] qobject: Parse non-finite numbers, as an extension

2016-06-16 Thread Eric Blake
On 06/16/2016 10:25 AM, Markus Armbruster wrote: > I think this commit mixes up parsing of non-finite numbers, which we may > or may not want, with general test improvements, which we'll want > regardless. Please split the patch. > > On the parsing of non-finite numbers: the code looks good to me

Re: [Qemu-devel] [PATCH 3/4] qobject: Parse non-finite numbers, as an extension

2016-06-16 Thread Markus Armbruster
I think this commit mixes up parsing of non-finite numbers, which we may or may not want, with general test improvements, which we'll want regardless. Please split the patch. On the parsing of non-finite numbers: the code looks good to me, but as long as we're not ready to extend QMP to include n

Re: [Qemu-devel] [PATCH 3/4] qobject: Parse non-finite numbers, as an extension

2016-06-16 Thread Markus Armbruster
Eric Blake writes: > There have been times in the past where we have been careless and > allowed non-finite values to escape as a 'number' type in QMP > output (such as before commit 27ff42e). This is in violation of > the JSON specification in RFC 7159, and usually caused by > floating-point di

[Qemu-devel] [PATCH 3/4] qobject: Parse non-finite numbers, as an extension

2016-06-09 Thread Eric Blake
There have been times in the past where we have been careless and allowed non-finite values to escape as a 'number' type in QMP output (such as before commit 27ff42e). This is in violation of the JSON specification in RFC 7159, and usually caused by floating-point division by 0 resulting in NaN, a