Re: [Qemu-devel] [PATCH 3/4] mirror: Keep target drained until graph changes are done

2019-07-26 Thread Max Reitz
On 26.07.19 13:36, Kevin Wolf wrote: > Am 26.07.2019 um 11:52 hat Max Reitz geschrieben: >> On 25.07.19 18:27, Kevin Wolf wrote: >>> Calling bdrv_drained_end() for target_bs can restarts requests too >>> early, so that they would execute on mirror_top_bs, which however has >>> already dropped all p

Re: [Qemu-devel] [PATCH 3/4] mirror: Keep target drained until graph changes are done

2019-07-26 Thread Kevin Wolf
Am 26.07.2019 um 11:52 hat Max Reitz geschrieben: > On 25.07.19 18:27, Kevin Wolf wrote: > > Calling bdrv_drained_end() for target_bs can restarts requests too > > early, so that they would execute on mirror_top_bs, which however has > > already dropped all permissions. > > > > Keep the target nod

Re: [Qemu-devel] [PATCH 3/4] mirror: Keep target drained until graph changes are done

2019-07-26 Thread Max Reitz
On 25.07.19 18:27, Kevin Wolf wrote: > Calling bdrv_drained_end() for target_bs can restarts requests too > early, so that they would execute on mirror_top_bs, which however has > already dropped all permissions. > > Keep the target node drained until all graph changes have completed. > > Signed-

Re: [Qemu-devel] [PATCH 3/4] mirror: Keep target drained until graph changes are done

2019-07-25 Thread Eric Blake
On 7/25/19 11:27 AM, Kevin Wolf wrote: > Calling bdrv_drained_end() for target_bs can restarts requests too restart > early, so that they would execute on mirror_top_bs, which however has > already dropped all permissions. > > Keep the target node drained until all graph changes have completed.

[Qemu-devel] [PATCH 3/4] mirror: Keep target drained until graph changes are done

2019-07-25 Thread Kevin Wolf
Calling bdrv_drained_end() for target_bs can restarts requests too early, so that they would execute on mirror_top_bs, which however has already dropped all permissions. Keep the target node drained until all graph changes have completed. Signed-off-by: Kevin Wolf --- block/mirror.c | 14 ++