Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-19 Thread Anthony PERARD
On Thu, Jul 19, 2012 at 4:37 PM, Stefano Stabellini wrote: > > Anthony, can you write a patch to change the behavior in > qemu-xen-traditional too? Yes. -- Anthony PERARD

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-19 Thread Stefano Stabellini
On Thu, 19 Jul 2012, Paolo Bonzini wrote: > Il 17/07/2012 20:06, Stefano Stabellini ha scritto: > > On Tue, 17 Jul 2012, Anthony PERARD wrote: > >> This patch add some calls to xen_modified_memory to notify Xen about > >> dirtybits > >> during migration. > >> > >> Signed-off-by: Anthony PERARD >

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-19 Thread Anthony PERARD
On 19/07/12 12:50, Avi Kivity wrote: On 07/19/2012 02:41 PM, Anthony PERARD wrote: On 17/07/12 19:36, Stefano Stabellini wrote: On Tue, 17 Jul 2012, Avi Kivity wrote: How about pushing the call into cpu_physical_memory_set_dirty_flags()? Would that reduce the number of call sites? Pushing th

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-19 Thread Paolo Bonzini
Il 17/07/2012 20:06, Stefano Stabellini ha scritto: > On Tue, 17 Jul 2012, Anthony PERARD wrote: >> This patch add some calls to xen_modified_memory to notify Xen about >> dirtybits >> during migration. >> >> Signed-off-by: Anthony PERARD >> --- >> exec.c |4 >> memory.c |2 ++ >>

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-19 Thread Avi Kivity
On 07/19/2012 02:41 PM, Anthony PERARD wrote: > On 17/07/12 19:36, Stefano Stabellini wrote: >> On Tue, 17 Jul 2012, Avi Kivity wrote: >>> How about pushing the call into cpu_physical_memory_set_dirty_flags()? >>> Would that reduce the number of call sites? >> >> Pushing the calls to cpu_physical_m

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-19 Thread Anthony PERARD
On 17/07/12 19:36, Stefano Stabellini wrote: On Tue, 17 Jul 2012, Avi Kivity wrote: How about pushing the call into cpu_physical_memory_set_dirty_flags()? Would that reduce the number of call sites? Pushing the calls to cpu_physical_memory_set_dirty_flags and cpu_physical_memory_set_dirty_rang

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-18 Thread Avi Kivity
On 07/17/2012 09:36 PM, Stefano Stabellini wrote: > On Tue, 17 Jul 2012, Avi Kivity wrote: >> On 07/17/2012 04:59 PM, Anthony PERARD wrote: >> >> >> >> This is pretty ugly. An alternative is to set up a periodic bitmap scan >> >> that looks at the qemu dirty bitmap and calls xen_modified_memory()

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-17 Thread Stefano Stabellini
On Tue, 17 Jul 2012, Avi Kivity wrote: > On 07/17/2012 04:59 PM, Anthony PERARD wrote: > >> > >> This is pretty ugly. An alternative is to set up a periodic bitmap scan > >> that looks at the qemu dirty bitmap and calls xen_modified_memory() for > >> dirty page ranges, and clears the bitmap for th

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-17 Thread Stefano Stabellini
On Tue, 17 Jul 2012, Anthony PERARD wrote: > This patch add some calls to xen_modified_memory to notify Xen about dirtybits > during migration. > > Signed-off-by: Anthony PERARD > --- > exec.c |4 > memory.c |2 ++ > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-17 Thread Avi Kivity
On 07/17/2012 04:59 PM, Anthony PERARD wrote: >> >> This is pretty ugly. An alternative is to set up a periodic bitmap scan >> that looks at the qemu dirty bitmap and calls xen_modified_memory() for >> dirty page ranges, and clears the bitmap for the next pass. Is it >> workable? > > I don't thi

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-17 Thread Anthony PERARD
On 17/07/12 14:37, Avi Kivity wrote: On 07/17/2012 04:30 PM, Anthony PERARD wrote: This patch add some calls to xen_modified_memory to notify Xen about dirtybits during migration. diff --git a/exec.c b/exec.c index c9fa17d..9f7a4f7 100644 --- a/exec.c +++ b/exec.c @@ -3438,6 +3438,7 @@ void cpu

Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-17 Thread Avi Kivity
On 07/17/2012 04:30 PM, Anthony PERARD wrote: > This patch add some calls to xen_modified_memory to notify Xen about dirtybits > during migration. > > diff --git a/exec.c b/exec.c > index c9fa17d..9f7a4f7 100644 > --- a/exec.c > +++ b/exec.c > @@ -3438,6 +3438,7 @@ void cpu_physical_memory_rw(targ

[Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.

2012-07-17 Thread Anthony PERARD
This patch add some calls to xen_modified_memory to notify Xen about dirtybits during migration. Signed-off-by: Anthony PERARD --- exec.c |4 memory.c |2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index c9fa17d..9f7a4f7 100644 --- a/exec.c +