Re: [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-12-06 Thread Stefan Hajnoczi
On Thu, Dec 05, 2013 at 11:34:28AM +0100, Paolo Bonzini wrote: > Il 05/12/2013 10:24, Stefan Hajnoczi ha scritto: > >> > > >> > That's what already happens actually. vring_push has > >> > > >> > > >> > +g_slice_free(VirtQueueElement, elem); > >> > + > >> > /* Don't touch vring if a fat

Re: [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 10:24, Stefan Hajnoczi ha scritto: >> > >> > That's what already happens actually. vring_push has >> > >> > >> > +g_slice_free(VirtQueueElement, elem); >> > + >> > /* Don't touch vring if a fatal error occurred */ >> > if (vring->broken) { >> > return; >> >

Re: [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-12-05 Thread Stefan Hajnoczi
On Wed, Dec 04, 2013 at 06:40:30PM +0100, Paolo Bonzini wrote: > Il 04/12/2013 15:06, Stefan Hajnoczi ha scritto: > > On Thu, Oct 10, 2013 at 05:07:18PM +0200, Paolo Bonzini wrote: > >> @@ -298,30 +278,31 @@ static void handle_notify(EventNotifier *e) > >> vring_disable_notification(s->vde

Re: [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-12-04 Thread Paolo Bonzini
Il 04/12/2013 15:06, Stefan Hajnoczi ha scritto: > On Thu, Oct 10, 2013 at 05:07:18PM +0200, Paolo Bonzini wrote: >> @@ -298,30 +278,31 @@ static void handle_notify(EventNotifier *e) >> vring_disable_notification(s->vdev, &s->vring); >> >> for (;;) { >> -head = vring

Re: [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-12-04 Thread Stefan Hajnoczi
On Thu, Oct 10, 2013 at 05:07:18PM +0200, Paolo Bonzini wrote: > @@ -298,30 +278,31 @@ static void handle_notify(EventNotifier *e) > vring_disable_notification(s->vdev, &s->vring); > > for (;;) { > -head = vring_pop(s->vdev, &s->vring, iov, end, &out_num, > &in_num)

[Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-10-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/block/dataplane/virtio-blk.c | 85 ++--- hw/virtio/dataplane/vring.c | 51 +- include/hw/virtio/dataplane/vring.h | 6 +-- 3 files changed, 66 insertions(+), 76 deletions(-) diff --git a/hw/block