Re: [Qemu-devel] [PATCH 3/4] block: add 'speed' optional parameter to block-stream

2012-04-25 Thread Luiz Capitulino
On Wed, 25 Apr 2012 11:56:51 +0100 Stefan Hajnoczi wrote: > On Tue, Apr 24, 2012 at 8:31 PM, Luiz Capitulino > wrote: > > On Mon, 23 Apr 2012 16:39:48 +0100 > > Stefan Hajnoczi wrote: > > > >> Allow streaming operations to be started with an initial speed limit. > >> This eliminates the window

Re: [Qemu-devel] [PATCH 3/4] block: add 'speed' optional parameter to block-stream

2012-04-25 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 8:31 PM, Luiz Capitulino wrote: > On Mon, 23 Apr 2012 16:39:48 +0100 > Stefan Hajnoczi wrote: > >> Allow streaming operations to be started with an initial speed limit. >> This eliminates the window of time between starting streaming and >> issuing block-job-set-speed.  Us

Re: [Qemu-devel] [PATCH 3/4] block: add 'speed' optional parameter to block-stream

2012-04-24 Thread Luiz Capitulino
On Mon, 23 Apr 2012 16:39:48 +0100 Stefan Hajnoczi wrote: > Allow streaming operations to be started with an initial speed limit. > This eliminates the window of time between starting streaming and > issuing block-job-set-speed. Users should use the new optional 'speed' > parameter instead so th

[Qemu-devel] [PATCH 3/4] block: add 'speed' optional parameter to block-stream

2012-04-23 Thread Stefan Hajnoczi
Allow streaming operations to be started with an initial speed limit. This eliminates the window of time between starting streaming and issuing block-job-set-speed. Users should use the new optional 'speed' parameter instead so that speed limits are in effect immediately when the job starts. Sign

Re: [Qemu-devel] [PATCH 3/4] block: add 'speed' optional parameter to block-stream

2012-04-23 Thread Paolo Bonzini
Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto: > +/* Only set speed when necessary to avoid NotSupported error */ > +if (speed != 0) { > +Error *local_err = NULL; > + > +block_job_set_speed(job, speed, &local_err); > +if (error_is_set(&local_err)) { > +