Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris

2012-03-27 Thread Peter Portante
There exists a simple patch that changes the wait loop timer to use CLOCK_MONOTONIC. See https://github.com/portante/qemu/commit/35c92daa9784882153c6d8b0e15e8c8f181d6e8a . -peter On Tue, Mar 27, 2012 at 12:00 PM, Jan Kiszka wrote: > On 2012-03-27 17:52, Paolo Bonzini wrote: > > Il 27/03/2012 17

Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris

2012-03-27 Thread Paolo Bonzini
Il 24/03/2012 17:26, Lee Essen ha scritto: > Dynticks was limited to linux. This patch adds Solaris support > and ensures a CLOCK_HIGHRES clock is used which is the optimal > setup for Solaris systems. Looks good, but I would prefer if you tested for timer_create in configure and use #ifdef CONFIG

Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris

2012-03-27 Thread Jan Kiszka
On 2012-03-27 17:52, Paolo Bonzini wrote: > Il 27/03/2012 17:08, Jan Kiszka ha scritto: +#if defined(__sun__) +if (timer_create(CLOCK_HIGHRES, &ev, &host_timer)) { +#else if (timer_create(CLOCK_REALTIME, &ev, &host_timer)) { +#endif >>> >>> This should be #ifdef CL

Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris

2012-03-27 Thread Paolo Bonzini
Il 27/03/2012 17:08, Jan Kiszka ha scritto: >>> +#if defined(__sun__) >>> +if (timer_create(CLOCK_HIGHRES, &ev, &host_timer)) { >>> +#else >>> if (timer_create(CLOCK_REALTIME, &ev, &host_timer)) { >>> +#endif >> >> This should be #ifdef CLOCK_HIGHRES. > > Are we sure about this is and wil

Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris

2012-03-27 Thread Jan Kiszka
On 2012-03-27 17:01, Paolo Bonzini wrote: > Il 24/03/2012 17:26, Lee Essen ha scritto: >> Dynticks was limited to linux. This patch adds Solaris support >> and ensures a CLOCK_HIGHRES clock is used which is the optimal >> setup for Solaris systems. > > Looks good, but I would prefer if you tested

[Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris

2012-03-24 Thread Lee Essen
Dynticks was limited to linux. This patch adds Solaris support and ensures a CLOCK_HIGHRES clock is used which is the optimal setup for Solaris systems. Signed-off-by: Lee Essen --- qemu-timer.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/qemu-timer.c b/