Re: [Qemu-devel] [PATCH 3/3] xics: report errors with the QEMU Error API

2016-02-25 Thread David Gibson
On Thu, Feb 25, 2016 at 07:02:25PM +0100, Greg Kurz wrote: > Using the return value to report errors is error prone: > - xics_alloc() returns -1 on error but spapr_vio_busdev_realize() errors > on 0 > - xics_alloc_block() returns the unclear value of ics->offset - 1 on error > but both rtas_ibm

[Qemu-devel] [PATCH 3/3] xics: report errors with the QEMU Error API

2016-02-25 Thread Greg Kurz
Using the return value to report errors is error prone: - xics_alloc() returns -1 on error but spapr_vio_busdev_realize() errors on 0 - xics_alloc_block() returns the unclear value of ics->offset - 1 on error but both rtas_ibm_change_msi() and spapr_phb_realize() error on 0 This patch turns xi